C# 8 Support

azure-pipelines.yml

@@ -12,7 +12,7 @@ jobs:
 
   variables:
     buildConfiguration: 'Release'
-    dotnetCoreVersion: '3.0.100-preview6-012264'
+    dotnetCoreVersion: '3.0.100-preview8-013656'
 
   steps:
   - task: DotNetCoreInstaller@0

build/binder_specifications/GLES.json

@@ -20869,14 +20869,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters containing the name of the uniform block whose index\n/// to retrieve.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
+              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters containing the name of the uniform block whose index\n/// to retrieve.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -81994,7 +81996,7 @@
   "OutputFolder": "OpenGL",
   "Name": "GLES",
   "ClassName": "GL",
-  "Version": null,
+  "Version": "",
   "FunctionPrefix": "gl",
   "SymbolLoaderName": "Silk.NET.Core.Loader.EGLSymbolLoader.Loader",
   "Names": {

build/binder_specifications/OpenGL (Compatibility Profile).json

@@ -21340,14 +21340,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
+              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -54698,7 +54700,9 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 2
                 }
@@ -54712,7 +54716,7 @@
                   ]
                 }
               ],
-              "Doc": "/// <summary>\r\n/// Return the polygon stipple pattern.\r\n/// </summary>\r\n/// <param name=\"mask\">\r\n/// To be added.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n",
+              "Doc": "/// <summary>\r\n/// Return the polygon stipple pattern.\r\n/// </summary>\r\n/// <param name=\"mask\">\r\n/// To be added.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -59557,7 +59561,9 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
@@ -59571,7 +59577,7 @@
                   ]
                 }
               ],
-              "Doc": "/// <summary>\r\n/// Set the polygon stippling pattern.\r\n/// </summary>\r\n/// <param name=\"mask\">\r\n/// To be added.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n",
+              "Doc": "/// <summary>\r\n/// Set the polygon stippling pattern.\r\n/// </summary>\r\n/// <param name=\"mask\">\r\n/// To be added.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -89082,14 +89088,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
+              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -281753,14 +281761,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"code\">\r\n/// To be added.\r\n/// This parameter contains 0 elements.\r\n/// </param>\r\n",
+              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"code\">\r\n/// To be added.\r\n/// This parameter's element count is computed from .\r\n/// </param>\r\n",
               "ExtensionName": "SUN"
             },
             {
@@ -281823,14 +281833,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"code\">\r\n/// To be added.\r\n/// This parameter contains 0 elements.\r\n/// </param>\r\n",
+              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"code\">\r\n/// To be added.\r\n/// This parameter's element count is computed from .\r\n/// </param>\r\n",
               "ExtensionName": "SUN"
             },
             {
@@ -281893,14 +281905,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"code\">\r\n/// To be added.\r\n/// This parameter contains 0 elements.\r\n/// </param>\r\n",
+              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"code\">\r\n/// To be added.\r\n/// This parameter's element count is computed from .\r\n/// </param>\r\n",
               "ExtensionName": "SUN"
             }
           ],
@@ -284688,14 +284702,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 2
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"points\">\r\n/// To be added.\r\n/// This parameter contains 0 elements.\r\n/// </param>\r\n",
+              "Doc": "/// <summary>\r\n/// To be added.\r\n/// </summary>\r\n/// <param name=\"points\">\r\n/// To be added.\r\n/// This parameter's element count is computed from .\r\n/// </param>\r\n",
               "ExtensionName": "SGIS"
             }
           ],
@@ -288908,7 +288924,7 @@
   "OutputFolder": "OpenGL",
   "Name": "OpenGL (Compatibility Profile)",
   "ClassName": "GL",
-  "Version": null,
+  "Version": "",
   "FunctionPrefix": "gl",
   "SymbolLoaderName": "Silk.NET.Core.Loader.GLSymbolLoader.Loader",
   "Names": {

build/binder_specifications/OpenGL.json

@@ -15334,14 +15334,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
+              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -62130,14 +62132,16 @@
                   "Count": {
                     "_count": 0,
                     "ValueReference": null,
-                    "ComputedFromNames": []
+                    "ComputedFromNames": [
+                      ""
+                    ]
                   },
                   "Flow": 1
                 }
               ],
               "GenericTypeParameters": [],
               "Attributes": [],
-              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter contains 0 elements.\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
+              "Doc": "/// <summary>\r\n/// Retrieve the index of a named uniform block.\r\n/// </summary>\r\n/// <param name=\"program\">\r\n/// Specifies the name of a program containing the uniform block.\r\n/// </param>\r\n/// <param name=\"uniformBlockName\">\r\n/// Specifies the address an array of characters to containing the name of the uniform block whose\n/// index to retrieve.\r\n/// This parameter's element count is computed from .\r\n///\r\n/// </param>\r\n/// <returns>See summary.</returns>\r\n",
               "ExtensionName": "Core"
             },
             {
@@ -155904,7 +155908,7 @@
   "OutputFolder": "OpenGL",
   "Name": "OpenGL",
   "ClassName": "GL",
-  "Version": null,
+  "Version": "",
   "FunctionPrefix": "gl",
   "SymbolLoaderName": "Silk.NET.Core.Loader.GLSymbolLoader.Loader",
   "Names": {

src/Core/BuildTools/Bind/BindOptions.cs

@@ -4,8 +4,16 @@
 // of the MIT license. See the LICENSE file for details.
 
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using CommandLine;
 
+// nullable stays disabled since else the compiler produces warnings cause we don't initialize the variables.
+// all of the properties are required, therefore all of them will be not-null anyways.
+// marked them with the attribute.
+
+// !! TAKE CARE IF ADDING ADDITIONAL ARGUMENTS !!
+#nullable disable
+
 namespace Silk.NET.BuildTools.Bind
 {
     /// <summary>
@@ -23,6 +31,7 @@ public sealed class BindOptions
             HelpText = "The input files to write.",
             Required = true
         )]
+        [NotNull]
         public IEnumerable<string> InputFiles { get; set; }
 
         /// <summary>
@@ -35,6 +44,7 @@ public sealed class BindOptions
             HelpText = "The base output path where the binder will write the generated files.",
             Required = true
         )]
+        [NotNull]
         public string OutputPath { get; set; }
 
         /// <summary>
@@ -47,6 +57,7 @@ public sealed class BindOptions
             HelpText = "The path to the license header.",
             Required = true
         )]
+        [NotNull]
         public string License { get; set; }
 
         /// <summary>
@@ -59,6 +70,7 @@ public sealed class BindOptions
             HelpText = "The path to the binding's props file.",
             Required = true
         )]
+        [NotNull]
         public string Props { get; set; }
     }
 }

src/Core/BuildTools/Bind/Binder.cs

@@ -10,6 +10,8 @@
 using Newtonsoft.Json;
 using Silk.NET.BuildTools.Common;
 
+#nullable disable
+
 namespace Silk.NET.BuildTools.Bind
 {
     /// <summary>

src/Core/BuildTools/Bind/Overloading/ArrayParameterOverloader.cs

@@ -50,7 +50,7 @@ public static bool IsApplicable(Function function)
 
             var lastParameter = function.Parameters.Last();
 
-            if (!lastParameter.Type.IsPointer)
+            if (lastParameter.Type != null && !lastParameter.Type.IsPointer)
             {
                 return false;
             }
@@ -83,6 +83,11 @@ public IEnumerable<Overload> CreateOverloads(Function function)
 
             var arrayParameter = function.Parameters.Last();
             var arrayParameterType = arrayParameter.Type;
+
+            if (arrayParameterType is null)
+            {
+                throw new ArgumentNullException(nameof(Function) + "." + nameof(Function.Parameters) + "." + nameof(Parameter.Type));
+            }
 
             var newName = function.Name.Singularize(false);
             var newParameters = SkipLastExtension.SkipLast(new List<Parameter>(function.Parameters), 2).ToList();

src/Core/BuildTools/Bind/Overloading/FlowPointerOverloader.cs

@@ -17,7 +17,7 @@ public class FlowPointerOverloader : IFunctionOverloader
     {
         public IEnumerable<Overload> CreateOverloads(Function function)
         {
-            if (!function.Parameters.Any(x => x.Type.IsPointer && !x.Type.IsVoidPointer()))
+            if (!function.Parameters.Any(x => x.Type != null && x.Type.IsPointer && !x.Type.IsVoidPointer()))
             {
                 yield break;
             }
@@ -32,6 +32,9 @@ public IEnumerable<Overload> CreateOverloads(Function function)
             for (var i = 0; i < function.Parameters.Count; i++)
             {
                 var param = function.Parameters[i];
+                if (param.Type is null || param.Name is null)
+                    continue;
+
                 if (param.Type.IsPointer && !param.Type.IsVoidPointer())
                 {
                     var newParameterType = new TypeSignatureBuilder(param.Type)

src/Core/BuildTools/Bind/Overloading/IFunctionOverloader.cs

@@ -19,7 +19,6 @@ public interface IFunctionOverloader
         /// </summary>
         /// <param name="function">The base function.</param>
         /// <returns>A set of code blocks.</returns>
-        [NotNull]
-        IEnumerable<Overload> CreateOverloads([NotNull] Function function);
+        IEnumerable<Overload> CreateOverloads(Function function);
     }
 }

src/Core/BuildTools/Bind/Overloading/IntPtrOverloader.cs

@@ -28,6 +28,11 @@ public IEnumerable<Overload> CreateOverloads(Function function)
             for (var i = 0; i < function.Parameters.Count; i++)
             {
                 var parameter = function.Parameters[i];
+                if (parameter.Type is null)
+                {
+                    continue;
+                }
+
                 if (parameter.Type.IsIntPtr())
                 {
                     @params[i] = new ParameterSignatureBuilder(parameter)

src/Core/BuildTools/Bind/Overloading/Overload.cs

@@ -10,10 +10,6 @@ namespace Silk.NET.BuildTools.Bind.Overloading
 {
     public class Overload
     {
-        public Overload()
-        {
-        }
-
         public Overload(Function sig, StringBuilder code, bool @unsafe = false)
         {
             Signature = sig;