Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# 8 Support #40

Closed
wants to merge 46 commits into from
Closed

C# 8 Support #40

wants to merge 46 commits into from

Conversation

HurricanKai
Copy link
Member

Summary of the PR

Adds Usage Features C# 8 Adds, nullable reference types, readonly members, advanced Patterns, Index, Range where Applicable. (I don't know the Code base, so we will see how much needs to change)

Related issues, Discord discussions, or proposals

#39

Further Comments

I'll try to keep Commits using different new features separated, in case there's a decision to not use specific ones.

@HurricanKai HurricanKai changed the title C# 8 Support [WIP] C# 8 Support Aug 10, 2019
@HurricanKai
Copy link
Member Author

Last Commit Nicely Demonstrates how I plan to do this everywhere. Resolving any Warnings, and removing any referencing [NotNull] [ItemNotNull] etc. Attributes

@HurricanKai
Copy link
Member Author

Opened #41, this PR would greatly benefit & will need a revisit when (if) #41 is resolved.

@Perksey
Copy link
Member

Perksey commented Aug 14, 2019

Looking to get this merged as we have some breaking changes to do. Can you fix the build errors on the CI and then I'll merge it, complete or not.

We need to do a massive refactor to support Vulkan.

@HurricanKai
Copy link
Member Author

no local changes. merge when needed

@HurricanKai HurricanKai changed the title [WIP] C# 8 Support C# 8 Support Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants