New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# 8 Support #40
Closed
Closed
C# 8 Support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last Commit Nicely Demonstrates how I plan to do this everywhere. Resolving any Warnings, and removing any referencing |
* Start of Build Tools .Net Core 3 * Set .Net Core Version * Replace COMPSIZE Regex Parsing with Span Parsing * Replace Regex expression parsing with Span * Update Azure Pipelines * Simplify Azure Piplines * Update azure-pipelines.yml * Retrigger Pipelines
Looking to get this merged as we have some breaking changes to do. Can you fix the build errors on the CI and then I'll merge it, complete or not. We need to do a massive refactor to support Vulkan. |
Preview 8 is fully supported in production. No reason not to update.
no local changes. merge when needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds Usage Features C# 8 Adds, nullable reference types, readonly members, advanced Patterns,
Index
,Range
where Applicable. (I don't know the Code base, so we will see how much needs to change)Related issues, Discord discussions, or proposals
#39
Further Comments
I'll try to keep Commits using different new features separated, in case there's a decision to not use specific ones.