Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Configuration.ConfigurationManager Version #2232

Closed
noxe opened this issue Nov 20, 2023 · 10 comments
Closed

System.Configuration.ConfigurationManager Version #2232

noxe opened this issue Nov 20, 2023 · 10 comments

Comments

@noxe
Copy link

noxe commented Nov 20, 2023

Hi,

the current Microsoft.Data.SqlClient depends on the System.Configuration.ConfigurationManager Version 6.0.1 - which forces us the System.Drawing.Common Version 6.0 - which is not wanted since this is Win-Only - https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only

image

Is there any info on this? It would be at least helpful if there would be a newer release based on .net8 since System.Configuration.ConfigurationManager or the be more precise the System.Windows.Extensions does not depend on System.Drawing.Common anymore.

Any thoughts?

@Wraith2
Copy link
Contributor

Wraith2 commented Nov 20, 2023

Can you try the latest preview version and see if the dependency is now updated, i think it should have been.

@JRahnama JRahnama added this to Needs triage in SqlClient Triage Board via automation Nov 20, 2023
@JRahnama
Copy link
Member

@noxe have you tried referencing System.Configuration.ConfigurationManager with a newer version in your csproj to see the outcome?

@JRahnama JRahnama moved this from Needs triage to Needs Investigation in SqlClient Triage Board Nov 21, 2023
@noxe
Copy link
Author

noxe commented Nov 27, 2023

Can you try the latest preview version and see if the dependency is now updated, i think it should have been.

Hi - Nuget says it still references the same?

image

@noxe
Copy link
Author

noxe commented Nov 27, 2023

System.Configuration.ConfigurationManager

i do not see any difference when using System.Configuration.ConfigurationManager 8.0.0

@ErikEJ
Copy link
Contributor

ErikEJ commented Dec 30, 2023

S.C.C 8.0.0 no longer depends on System.Security.Permissions and therefore fixes this issue

ErikEJ added a commit to ErikEJ/SqlClient that referenced this issue Dec 30, 2023
as it has less dependencies than previous versions

fixes dotnet#2232
@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 25, 2024

@JRahnama @H-Yeo This is fixed in 5.2 preview 5

@H-Yeo
Copy link
Contributor

H-Yeo commented Jan 25, 2024

Javad looks like he goes through and helps to clean up dangling tickets. Thanks for point it out. Hopefully everything will be released today. We had a hiccup with one of the internal pipelines which prevented our release y'day. Thanks!

@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 25, 2024

@H-Yeo The package is on NuGet...

@H-Yeo
Copy link
Contributor

H-Yeo commented Jan 25, 2024

@H-Yeo The package is on NuGet...

Thanks. Davoud pushed out the release, and I'll be wrapping up the last of the Release Activities.

@kf-gonzalez
Copy link

Addressed by #2303

SqlClient Triage Board automation moved this from Needs Investigation to Closed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

6 participants