Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement | Add explicit version for major .NET version dependencies #2303

Merged
merged 8 commits into from Jan 23, 2024

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jan 18, 2024

I have also removed explicit references in test projects, they will just use the transitive reference

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 18, 2024

@David-Engel Wonder if it is time to abandon support for netstandard2.0 and netstandard2.1 ? Let me know and I will be happy to do a PR

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (900d051) 72.49% compared to head (1cbd946) 72.63%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
+ Coverage   72.49%   72.63%   +0.13%     
==========================================
  Files         310      310              
  Lines       61868    62125     +257     
==========================================
+ Hits        44854    45123     +269     
+ Misses      17014    17002      -12     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.84% <ø> (+0.14%) ⬆️
netfx 70.03% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview5 milestone Jan 19, 2024
@DavoudEshtehari DavoudEshtehari added this to In progress in SqlClient v5.2 via automation Jan 19, 2024
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 19, 2024

@DavoudEshtehari Should I be concerned about the test failures?

@H-Yeo
Copy link
Contributor

H-Yeo commented Jan 19, 2024

@ErikEJ , I've re-run the failed Pipeline tests, and all the tests have passed. It's on the final step Merge Code, and I usually never see any problems when it get's that far. Thank-you for making sure the build goes green. Cheers.

@DavoudEshtehari DavoudEshtehari moved this from In progress to Done in SqlClient v5.2 Jan 19, 2024
@DavoudEshtehari DavoudEshtehari moved this from Done to In progress in SqlClient v5.2 Jan 19, 2024
@DavoudEshtehari DavoudEshtehari moved this from In progress to Review in progress in SqlClient v5.2 Jan 19, 2024
@David-Engel
Copy link
Contributor

Wonder if it is time to abandon support for netstandard2.0 and netstandard2.1 ? Let me know and I will be happy to do a PR

That's a major version bump task. I think we'll go to 6.0 after 5.2, so it's something we'll consider.

@JRahnama
Copy link
Member

LGTM, only the naming could be improved to something more appropriate identifying net8 and upper.

Net6 will be out of support by the end of this year and this will become the only version props for the driver. We can adjust the name to version.props on that time.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 22, 2024

@JRahnama any suggestions for a better name? Versioncurrent.props ?

Version latest.props?

@JRahnama
Copy link
Member

JRahnama commented Jan 22, 2024

Version latest.props?

Net8Plus

@JRahnama Javad Rahnama (SIMBA TECHNOLOGIES INC) Vendor any suggestions for a better name? Versioncurrent.props ?

Version latest.props?

We can either revers the order and set Net8 as the default version.props and add net6version.props for net6 or just change the name to Version8Compatible or something similar to it.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 23, 2024

@JRahnama I renamed the props file to VersionsNet8OrLater.props

SqlClient v5.2 automation moved this from Review in progress to Reviewer approved Jan 23, 2024
@JRahnama
Copy link
Member

/azurepipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DavoudEshtehari DavoudEshtehari changed the title Add explicit version for major .NET version dependencies Enhancement | Add explicit version for major .NET version dependencies Jan 23, 2024
@DavoudEshtehari DavoudEshtehari merged commit c8b70f1 into dotnet:main Jan 23, 2024
148 checks passed
SqlClient v5.2 automation moved this from Reviewer approved to Done Jan 23, 2024
@ErikEJ ErikEJ deleted the targets branch February 7, 2024 12:09
@ErikEJ ErikEJ restored the targets branch February 7, 2024 12:09
@ErikEJ ErikEJ deleted the targets branch February 7, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request netcore
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants