Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Porting SqlDataSourceEnumerator from System.Data.Sql #1428

Closed

Conversation

Kaur-Parminder
Copy link
Contributor

This PR ports feature from System.Data.Sql for SqlDataSourceEnumerator.GetDataSources Method . SNI changes will be available with next preview release.

  • Added SqlDataSourceEnumerator Public API methods
  • Added unit tests for feature.
  • endpoints for Native SNI

Porting SqlDataSourceEnumerater feature from System.Data.Sql
Netfx SNINativeWrapper changes
@Wraith2
Copy link
Contributor

Wraith2 commented Dec 10, 2021

Is there going to be a managed implementation provided for the non-windows builds? If so would it be possible to use that one on all builds and avoid introducing new code that perpetuates the managed vs native sni.

@Kaur-Parminder
Copy link
Contributor Author

Is there going to be a managed implementation provided for the non-windows builds?
Yes
If so would it be possible to use that one on all builds and avoid introducing new code that perpetuates the managed vs native sni.
I will be getting feedback from team on both implementations and discuss internally, How we want to manage it moving forward. It can be with AppContext Switch, not sure. I will keep you posted here.

@Wraith2
Copy link
Contributor

Wraith2 commented Dec 10, 2021

Ok. As long as it's a consideration. I can see that it might be a good first step to use the native implementation so the results can be tested. In the long term the plan to move this library to a managed only implementation would mean that it's important to have a high quality managed implementation.

addressing reviewer's comment
@Kaur-Parminder Kaur-Parminder added 📄 Native SNI 🆕 Public API Use this label for new API additions to the driver. labels Dec 13, 2021
@Kaur-Parminder
Copy link
Contributor Author

I am closing this PR as all the work done here is moved to #1430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 Public API Use this label for new API additions to the driver. 📄 Native SNI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants