Feature | Add SqlDataSourceEnumerator #1430

Kaur-Parminder · 2021-12-13T17:59:24Z

Added UDP Broadcast to SSRP

Details about Request/Response/timeouts are available in specification

Update:

Ports Native code System.Data.Sql
Added Native and Managed Helper for parsing enumeration results from SNI and Managed SSRP respectively.
Integrated the Managed and Native Implementation using AppContext condition to switch to choose one.
This PR will remain in Draft because this requires updated SNI package to build which will be released earlier before merging this PR.
Added Unit Test

Added UDP Broadcast to SSRP

…Native and Managed) Added SqlDataSourceEnumerator Public API and AppContext for Helpers (Native and Managed)

Added AppContext change to unit test

…to avoid heap corruption issue

# Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs # src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj

…a from SQL Browser

DavoudEshtehari

For the record:

Sanitize your code by considering the warning and messages in the Error List.
Include traces using EventSource as much as possible?
Add documentation for the public APIs.
Include the new public APIs in ref files.
Add inline comments with reference.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlDataSourceEnumeratorTest.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumerator.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorManagedHelper.cs

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorNativeHelper.cs

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlDataSourceEnumeratorTest.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SSRP.cs

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlDataSourceEnumeratorTest.cs

license

exclude appcontext test

Comments and url references

review comment

fix strbuilder overwrite

VS Suggestions

body expression for GetTimeoutSeconds

created util for sqldatasourceenumerator

more utils

license for util file

native sni managed sni unicode

DavoudEshtehari · 2022-03-04T20:24:49Z

src/Microsoft.Data.SqlClient/netcore/src/Interop/SNINativeMethodWrapper.Common.cs

+        [DllImport(SNI, CallingConvention = CallingConvention.Cdecl, EntryPoint = "SNIServerEnumOpenWrapper")]
+        internal static extern IntPtr SNIServerEnumOpen();
+
+        [DllImport(SNI, CallingConvention = CallingConvention.Cdecl, EntryPoint = "SNIServerEnumCloseWrapper")]
+        internal static extern void SNIServerEnumClose([In] IntPtr packet);
+
+        [DllImport(SNI, CallingConvention = CallingConvention.Cdecl, EntryPoint = "SNIServerEnumReadWrapper", CharSet = CharSet.Unicode)]
+        internal static extern int SNIServerEnumRead([In] IntPtr packet,
+                                                     [In][MarshalAs(UnmanagedType.LPArray)] char[] readBuffer,
+                                                     [In] int bufferLength,
+                                                     [MarshalAs(UnmanagedType.Bool)] out bool more);


These lines should be moved into SNINativeMethodWrapper.Windows.cs. And modify the native helper accordingly.

SNI Update

This reverts commit 7aebf45.

SqlDataSourceEnumerator test update and different file for unix, windows

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorManagedHelper.cs

...crosoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj

Added UDP Broadcast to SSRP

dcd629b

Added UDP Broadcast to SSRP

Kaur-Parminder added the Ⓜ️ Managed SNI Use this label if the issue/PR relates to issues in Managed SNI label Dec 13, 2021

Added SqlDataSourceEnumerator Public API and AppContext for Helpers (…

742107c

…Native and Managed) Added SqlDataSourceEnumerator Public API and AppContext for Helpers (Native and Managed)

Kaur-Parminder marked this pull request as draft December 21, 2021 17:55

Kaur-Parminder changed the title ~~Managed Implementation for SqlDataSourceEnumerator: Phase 1~~ Implementation for SqlDataSourceEnumerator: Managed, Native Dec 21, 2021

Kaur-Parminder mentioned this pull request Dec 21, 2021

[WIP] Porting SqlDataSourceEnumerator from System.Data.Sql #1428

Closed

Added AppContext change to unit test

8374240

Added AppContext change to unit test

DavoudEshtehari added the 📄 Native SNI label Feb 3, 2022

DavoudEshtehari added this to the 5.0.0-preview1 milestone Feb 3, 2022

DavoudEshtehari changed the title ~~Implementation for SqlDataSourceEnumerator: Managed, Native~~ Feature | Add SqlDataSourceEnumerator Feb 3, 2022

Kaur-Parminder added 2 commits February 7, 2022 09:57

Increased recieve buffer size to match to native recieve buffer size …

d629a1c

…to avoid heap corruption issue

reset to d629a1c

0bc15f8

Kaur-Parminder force-pushed the MSDEnumerator branch from 5b6e9b9 to 0bc15f8 Compare February 7, 2022 19:46

Merge remote-tracking branch 'Upstream/main' into MSDEnumerator

68ae3ba

# Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs # src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj

Kaur-Parminder added 🆕 Public API Use this label for new API additions to the driver. and removed Ⓜ️ Managed SNI Use this label if the issue/PR relates to issues in Managed SNI 📄 Native SNI labels Feb 7, 2022

Added stopwatch to track time elapsed for max timeouts in recieve dat…

e2cca89

…a from SQL Browser

Kaur-Parminder requested review from DavoudEshtehari, johnnypham and JRahnama February 7, 2022 20:28

DavoudEshtehari modified the milestones: 5.0.0-preview1, 5.0.0-preview2 Feb 9, 2022

DavoudEshtehari reviewed Feb 9, 2022

View reviewed changes

Kaur-Parminder added 6 commits February 10, 2022 15:36

license

f47181a

license

exclude appcontext test

ec6e623

exclude appcontext test

Comments and url references

a611863

Comments and url references

review comment

a4d9de6

review comment

fix strbuilder overwrite

968183b

fix strbuilder overwrite

VS Suggestions

efa3d74

VS Suggestions

Kaur-Parminder added 4 commits February 24, 2022 15:49

body expression for GetTimeoutSeconds

2255f1a

body expression for GetTimeoutSeconds

created util for sqldatasourceenumerator

ce39cd7

created util for sqldatasourceenumerator

more utils

67f0bbf

more utils

license for util file

3f9ad32

license for util file

DavoudEshtehari modified the milestones: 5.0.0-preview2, 5.0.0-preview1 Feb 28, 2022

DavoudEshtehari and others added 3 commits March 2, 2022 11:51

fix (#2)

d93127c

native sni managed sni unicode

merge

58f8f15

changing back encoding to ASCII for SRRP except UDPbroadcast menthod

4ae25f2

Kaur-Parminder requested a review from JRahnama March 2, 2022 21:39

JRahnama approved these changes Mar 2, 2022

View reviewed changes

Kaur-Parminder marked this pull request as ready for review March 4, 2022 19:33

DavoudEshtehari requested changes Mar 4, 2022

View reviewed changes

Kaur-Parminder added 3 commits March 4, 2022 12:25

Noimplementation exception for Managed SNI and test update for same

3927340

SNI Update

7aebf45

SNI Update

Revert "SNI Update"

e7931b5

This reverts commit 7aebf45.

Kaur-Parminder mentioned this pull request Mar 7, 2022

Update SNI version #1537

Merged

Kaur-Parminder and others added 3 commits March 8, 2022 10:22

Merge branch 'dotnet:main' into main

855f69f

Merge branch 'main' into MSDEnumerator

81e26f6

Fix | SqlDSEnumerator net core (#3)

7ff8220

SqlDataSourceEnumerator test update and different file for unix, windows

johnnypham reviewed Mar 8, 2022

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorManagedHelper.cs Outdated Show resolved Hide resolved

Kaur-Parminder and others added 3 commits March 8, 2022 16:52

added test dependcy for ServiceController.dll

54b3c36

review comments

f09becc

Fix build issue

c0f6bad

johnnypham reviewed Mar 9, 2022

View reviewed changes

...crosoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj Outdated Show resolved Hide resolved

use TargetsWindows

36d6ade

DavoudEshtehari approved these changes Mar 9, 2022

View reviewed changes

johnnypham approved these changes Mar 9, 2022

View reviewed changes

DavoudEshtehari merged commit 7fba93b into dotnet:main Mar 9, 2022

DavoudEshtehari mentioned this pull request Aug 12, 2022

[Hotfix 4.1.1] | Parallelize SSRP requests when MSF is specified (#1578) #1708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature | Add SqlDataSourceEnumerator #1430

Feature | Add SqlDataSourceEnumerator #1430

Kaur-Parminder commented Dec 13, 2021 •

edited

DavoudEshtehari left a comment

DavoudEshtehari Mar 4, 2022 •

edited

Feature | Add SqlDataSourceEnumerator #1430

Feature | Add SqlDataSourceEnumerator #1430

Conversation

Kaur-Parminder commented Dec 13, 2021 • edited

DavoudEshtehari left a comment

Choose a reason for hiding this comment

DavoudEshtehari Mar 4, 2022 • edited

Choose a reason for hiding this comment

Kaur-Parminder commented Dec 13, 2021 •

edited

DavoudEshtehari Mar 4, 2022 •

edited