Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Perf | avoid boxing of SqlGuid in SqlBuffer (#2306)" #2311

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jan 22, 2024

This reverts commit 9602271.

(Which had bugs and very low test coverage)

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (838b931) 72.50% compared to head (a270a02) 72.48%.

Files Patch % Lines
...osoft/Data/SqlClient/Server/ValueUtilsSmi.netfx.cs 0.00% 2 Missing ⚠️
...qlClient/src/Microsoft/Data/SqlClient/SqlBuffer.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2311      +/-   ##
==========================================
- Coverage   72.50%   72.48%   -0.02%     
==========================================
  Files         310      310              
  Lines       61872    61873       +1     
==========================================
- Hits        44858    44847      -11     
- Misses      17014    17026      +12     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.70% <66.66%> (-0.01%) ⬇️
netfx 69.92% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview5 milestone Jan 23, 2024
@DavoudEshtehari DavoudEshtehari added the 💥 Regression Regression introduced from earlier PRs label Jan 23, 2024
@DavoudEshtehari DavoudEshtehari merged commit 4ca71d9 into dotnet:main Jan 23, 2024
148 checks passed
@ErikEJ ErikEJ deleted the pr-2306-revert branch February 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Regression Regression introduced from earlier PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants