Fix | Avoid enlistment of pooled connection in aborted transaction #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
cheenamalhotra
requested review from
karinazhou,
David-Engel,
DavoudEshtehari and
JRahnama
David-Engel
reviewed
Apr 28, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Show resolved
Hide resolved
Co-Authored-By: David Engel <dengel@magnitude.com>
David-Engel
reviewed
Apr 28, 2020
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDelegatedTransaction.cs
Outdated
Show resolved
Hide resolved
…t/SqlDelegatedTransaction.cs Co-Authored-By: David Engel <dengel@magnitude.com>
David-Engel
approved these changes
Apr 30, 2020
JRahnama
approved these changes
Apr 30, 2020
|
@cheenamalhotra will this fix also be backported? |
|
We are going to backport the fix to M.D.S v1.1 and System.Data.SqlClient in .NET Core, while for .NET Framework, @saurabh500 can confirm if this could be considered? |
|
The original issue was found in .net framework. It seems to me this needs backporting to .net framework too. Edit: Sorry, 1.1.* is targeting .net framework. |
This was referenced Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237 by dooming the connection when transaction ends externally (re-created PR #495) .
As of now, this fix is promising and does not send connection back to connection pool, hence avoiding enlistment in aborted transaction.
Alternatively, if we want to send connection back to pool, it needs to be in same state as any other connection in pool with no aborted transaction reference, but that doesn't seem likely to be achieved without complex changes in the driver that would also be a risky attempt. Investigations are in progress that will bring back same performance, but in order to address the issue on priority, I would propose this fix in the driver for end user application consistency.