Fix | Fix issue connecting with instance name from Unix environment #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
karinazhou,
DavoudEshtehari,
johnnypham and
JRahnama
karinazhou
approved these changes
Jan 8, 2021
DavoudEshtehari
approved these changes
Jan 8, 2021
JRahnama
approved these changes
Jan 8, 2021
|
Just to add on this: if the server only has named instances, then any attempt at opening a connection will throw an exception. My understanding is that this happens because in resolving "address\instance", the targeted data source becomes in fact "address", which would then point to a non-existing Sql Server. The fix should therefore cover this case too. Is my assumption correct? |
|
Yes, that's correct! |
|
Thanks for the blazing fast reply, @cheenamalhotra ! I am happy to hear I will not have to wait until v3 for this fix. 😁 Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #868