Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error messages for Enclave exceptions with forward link to troubleshooting guide. #994

Merged
merged 2 commits into from May 17, 2021

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview2 milestone Mar 19, 2021
@cheenamalhotra cheenamalhotra added this to In Progress in SqlClient v3.0 via automation Apr 7, 2021
@JRahnama
Copy link
Member

JRahnama commented Apr 7, 2021

LGTM, except a couple of non-blocking minor suggestions and a question.

SqlClient v3.0 automation moved this from In Progress to Reviewer Approved Apr 7, 2021
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the SQL Server instance is the correct term. If you agreed, update all the combinations, please.

…g-updates

# Conflicts:
#	src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.Designer.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.resx
@cheenamalhotra cheenamalhotra merged commit ca4957c into dotnet:main May 17, 2021
SqlClient v3.0 automation moved this from Reviewer Approved to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants