Commits on Jun 4, 2020

1. [Xamarin.Android.Tools.AndroidSdk] JdkInfo + JDK11 + Windows …

   Context: dotnet/android#4567
   
   Commit 36d7fee added support for JetBrains OpenJDK 11 detection on
   macOS and Linux.
   
   Lacking was *Windows* support for JetBrains OpenJDK 11, because of
   course it has to be different.
   
   In particular, OpenJDK 11 *moves the `jvm` library* for Windows.
   We checked for it in `{HomePath}\jre\**\jvm.dll` or
   `{HomePath}\lib\**\jvm.dll`, but neither of those exist.  Instead,
   OpenJDK 11 has `jvm.dll` in `{HomePath}\bin\server\jvm.dll`, which is
   also the only `.dll` file in the `.tar.gz` which exports the symbol
   `JNI_CreateJavaVM`.
   
   Update `JdkInfo` so that it looks for `{HomePath}\bin\server\jvm.dll`
   to populate `JdkInfo.JdkJvmPath`.

   

   jonpryor committed Jun 4, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for e08d123
   • Browse repository at this point

   Copy the full SHA

   e08d123 View commit details

   Browse the repository at this point in the history