[Xamarin.Android.Tools.AndroidSdk] JdkInfo + JDK11 + Windows #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#4567
Commit 36d7fee added support for JetBrains OpenJDK 11 detection on
macOS and Linux.
Lacking was Windows support for JetBrains OpenJDK 11, because of
course it has to be different.
In particular, OpenJDK 11 moves the
jvm
library for Windows.We checked for it in
{HomePath}\jre\**\jvm.dll
or{HomePath}\lib\**\jvm.dll
, but neither of those exist. Instead,OpenJDK 11 has
jvm.dll
in{HomePath}\bin\server\jvm.dll
, which isalso the only
.dll
file in the.tar.gz
which exports the symbolJNI_CreateJavaVM
.Update
JdkInfo
so that it looks for{HomePath}\bin\server\jvm.dll
to populate
JdkInfo.JdkJvmPath
.