AOT compilation now fails when invoking strip on Windows #3619

pjcollins · 2019-09-11T20:52:26Z

Steps to Reproduce

AOT compilation has recently broken on Windows. I believe this is fallout from some recent changes to no longer attempt to use shortened paths for tools in #2062. It looks like we've got an extra path escape attempt when invoking strip:

""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip"

  [aot-compiler stdout] AOTID 3581E20D-4E87-BD23-634B-437CDBBB6296
  [aot-compiler stdout] Compiled: 3/3
  [aot-compiler stdout] Executing the native assembler: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-
  androideabi-as"   -mfpu=vfp3 -o obj\Release\90\aot\armeabi-v7a\Xamarin.Android.Arch.Core.Common.dll\temp.s.o obj\Release\90\aot\armeabi-v7a\Xamarin.Andr
  oid.Arch.Core.Common.dll\temp.s
  [aot-compiler stdout] Executing the native linker: "C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-and
  roideabi-ld"  -shared -o obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp  obj\Release\90\aot\armeabi-v7a\Xamarin.Andro
  id.Arch.Core.Common.dll\temp.s.o
  [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androidea
  bi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp
  [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command,
  [aot-compiler stderr] operable program or batch file.
  [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterL
  ayout.dll failed.

Version Information

d16-4

Log File

binlog.zip

The text was updated successfully, but these errors were encountered:

jonathanpeppers · 2019-09-11T23:34:01Z

Hmm, it’s weird the tests we have are passing on Windows...

dellis1972 · 2019-09-12T07:46:03Z

I be the CI system paths for the ndk don't have a space in the path 🤦‍♂

dellis1972 · 2019-09-12T08:20:34Z

This is a bug in mono

command = g_strdup_printf ("\"%sstrip\" --strip-symbol=\\$a --strip-symbol=\\$d %s", wrap_path(tool_prefix), wrap_path(tmp_outfile_name));

Should fix: dotnet/android#3619 As it results in double quoting, which vanishes the effect and breaks AOT for XA on Windows. Let just quote the `strip` path as we do for `as` and `ld`. The actual error: [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command, [aot-compiler stderr] operable program or batch file. [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterL ayout.dll failed.

[aot] Do not put quotes around wrapped path Should fix: dotnet/android#3619 As it results in double quoting, which vanishes the effect and breaks AOT for XA on Windows. The actual error: [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command, [aot-compiler stderr] operable program or batch file. [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterLayout.dll failed.

@lewurm

[2019-08] [aot] Do not put quotes around wrapped path Should fix: dotnet/android#3619 As it results in double quoting, which vanishes the effect and breaks AOT for XA on Windows. The actual error: [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command, [aot-compiler stderr] operable program or batch file. [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterLayout.dll failed. Backport of #16792. /cc @lewurm @radekdoulik

Changes: mono/mono@cecda47...7ec17ba Context: dotnet#3619 Fixes AOT on Windows and adds aprofutil tool to mono SDK (aka mono android archive) Other changes include memory leak fix and thread name related issue.

Changes: mono/mono@cecda47...7ec17ba Fixes: dotnet#3619 Adds `aprofutil.exe` to the mono archive for Xamarin.Android use. Fix leaks when handling a few metadata attributes. Fix infrequent hangs in test-runner. [threads] do not convert NULL thread name.

Changes: mono/mono@cecda47...7ec17ba Fixes: #3619 Adds `aprofutil.exe` to the mono archive for Xamarin.Android use. Fix leaks when handling a few metadata attributes. Fix infrequent hangs in test-runner. [threads] do not convert NULL thread name.

brendanzagaeski · 2019-10-19T00:06:46Z

Release status update

A new Preview version has now been published that includes the fix for this item.

Fix included in Xamarin.Android 10.1.0.1.

Fix included on Windows in Visual Studio 2019 version 16.4 Preview 2. To try the Preview version that includes the fix, check for the latest updates in Visual Studio Preview.

(The fix is not relevant for macOS.)

Changes: mono/api-snapshot@fc50bc4...45a61d9 $ git diff --shortstat fc50bc4f...45a61d93 22 files changed, 775 insertions(+), 474 deletions(-) Changes: dotnet/cecil@a6c8f5e...a6a7f5c $ git diff --shortstat a6c8f5e1...a6a7f5c0 55 files changed, 818 insertions(+), 530 deletions(-) Changes: mono/corefx@1f87de3...49f1c45 $ git diff --shortstat e4f7102b...49f1c453 38 files changed, 1171 insertions(+), 419 deletions(-) Changes: dotnet/linker@ebe2a1f...e8d054b $ git diff --shortstat ebe2a1f4...e8d054bf 137 files changed, 5360 insertions(+), 1781 deletions(-) Changes: mono/mono@8946e49...18920a8 $ git diff --shortstat 8946e49a...18920a83 1811 files changed, 47240 insertions(+), 48331 deletions(-) Changes: xamarin/xamarin-android-api-compatibility@a61271e...50a3c52 $ git diff --shortstat a61271e0...50a3c52d 1 file changed, 2 insertions(+), 791 deletions(-) Fixes: #3619 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1005448 Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Context: https://github.com/dotnet/coreclr/issues/26370 Context: https://github.com/dotnet/coreclr/issues/26479 Context: https://github.com/dotnet/corefx/issues/40455 Context: https://github.com/dotnet/corefx/issues/40578 Context: mono/mono#7377 Context: mono/mono#12421 Context: mono/mono#12586 Context: mono/mono#14080 Context: mono/mono#14725 Context: mono/mono#14772 Context: mono/mono#15261 Context: mono/mono#15262 Context: mono/mono#15263 Context: mono/mono#15307 Context: mono/mono#15308 Context: mono/mono#15310 Context: mono/mono#15646 Context: mono/mono#15687 Context: mono/mono#15805 Context: mono/mono#15992 Context: mono/mono#15994 Context: mono/mono#15999 Context: mono/mono#16032 Context: mono/mono#16034 Context: mono/mono#16046 Context: mono/mono#16192 Context: mono/mono#16308 Context: mono/mono#16310 Context: mono/mono#16369 Context: mono/mono#16380 Context: mono/mono#16381 Context: mono/mono#16395 Context: mono/mono#16411 Context: mono/mono#16415 Context: mono/mono#16486 Context: mono/mono#16570 Context: mono/mono#16605 Context: mono/mono#16616 Context: mono/mono#16689 Context: mono/mono#16701 Context: mono/mono#16712 Context: mono/mono#16742 Context: mono/mono#16759 Context: mono/mono#16803 Context: mono/mono#16808 Context: mono/mono#16824 Context: mono/mono#16876 Context: mono/mono#16879 Context: mono/mono#16918 Context: mono/mono#16943 Context: mono/mono#16950 Context: mono/mono#16974 Context: mono/mono#17004 Context: mono/mono#17017 Context: mono/mono#17038 Context: mono/mono#17040 Context: mono/mono#17083 Context: mono/mono#17084 Context: mono/mono#17133 Context: mono/mono#17139 Context: mono/mono#17151 Context: mono/mono#17180 Context: mono/mono#17278 Context: mono/mono#17549 Context: mono/mono#17569 Context: mono/mono#17665 Context: mono/mono#17687 Context: mono/mono#17737 Context: mono/mono#17790 Context: mono/mono#17924 Context: mono/mono#17931 Context: https://github.com/mono/mono/issues/26758 Context: https://github.com/mono/mono/issues/37913 Context: xamarin/xamarin-macios#7005

[aot] Do not put quotes around wrapped path Should fix: dotnet/android#3619 As it results in double quoting, which vanishes the effect and breaks AOT for XA on Windows. The actual error: [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command, [aot-compiler stderr] operable program or batch file. [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterLayout.dll failed. Commit migrated from mono/mono@131b3a9

pjcollins added this to the d16-4 milestone Sep 11, 2019

pjcollins mentioned this issue Sep 11, 2019

Xamarin.Android app starts up slower when built using VS2019 #3366

Closed

jonathanpeppers assigned dellis1972 Sep 11, 2019

jonathanpeppers self-assigned this Sep 11, 2019

radekdoulik mentioned this issue Sep 12, 2019

[aot] Do not put quotes around wrapped path mono/mono#16792

Merged

monojenkins mentioned this issue Sep 13, 2019

[2019-08] [aot] Do not put quotes around wrapped path mono/mono#16820

Merged

monojenkins closed this as completed in mono/mono#16792 Sep 13, 2019

radekdoulik mentioned this issue Sep 17, 2019

Bump to mono@7ec17ba1be9bd08d9d991d10414df2b78710bc18 #3641

Closed

jonpryor mentioned this issue Sep 17, 2019

Bump to mono/mono/2019-08@7ec17ba1 #3642

Merged

pjcollins mentioned this issue Sep 19, 2019

AOT compilation fails when invoking ld on Window #3651

Closed

brendanzagaeski mentioned this issue Sep 25, 2019

AOT compilation failure - VS2019 16.4.0 Preview 1.0 #3681

Closed

brendanzagaeski modified the milestones: d16-4, In preview: 10.1 (d16-4) Oct 19, 2019

ghost locked as resolved and limited conversation to collaborators Jun 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AOT compilation now fails when invoking strip on Windows #3619

AOT compilation now fails when invoking strip on Windows #3619

pjcollins commented Sep 11, 2019

jonathanpeppers commented Sep 11, 2019

dellis1972 commented Sep 12, 2019

dellis1972 commented Sep 12, 2019

brendanzagaeski commented Oct 19, 2019

AOT compilation now fails when invoking strip on Windows #3619

AOT compilation now fails when invoking strip on Windows #3619

Comments

pjcollins commented Sep 11, 2019

Steps to Reproduce

Version Information

Log File

jonathanpeppers commented Sep 11, 2019

dellis1972 commented Sep 12, 2019

dellis1972 commented Sep 12, 2019

brendanzagaeski commented Oct 19, 2019