Use a proxy server if specified #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#2123 Implement proxy support for the Java HTTP client by "translating" the proxy information specified in `HttpClientHandler.Proxy` to the format accepted and expected by the Java client. Since the translation may involve a DNS lookup, it is performed in a separate task. No caching is attempted in our client code.
dellis1972
approved these changes
Nov 5, 2018
jonpryor
reviewed
Nov 5, 2018
| @@ -260,7 +260,7 @@ protected virtual IHostnameVerifier GetSSLHostnameVerifier (HttpsURLConnection c | |||
| URL java_url = new URL (EncodeUrl (redirectState.NewUrl)); | |||
| URLConnection java_connection; | |||
| if (UseProxy) | |||
| java_connection = java_url.OpenConnection (); | |||
| java_connection = java_url.OpenConnection (await GetJavaProxy (redirectState.NewUrl, cancellationToken)); | |||
There was a problem hiding this comment.
Does this constitute a "redirect"? Do we need to worry about Authentication headers here?
There was a problem hiding this comment.
It doesn't constitute a redirect per se, look at the code a few lines above:
var redirectState = new RequestRedirectionState {
NewUrl = request.RequestUri,
RedirectCounter = 0,
Method = request.Method
};
while (true) {
URL java_url = new URL (EncodeUrl (redirectState.NewUrl));if there is a redirect, the URL used here will reflect it, otherwise it's the request URL.
Regarding the authentication headers, we do need to worry about them but they have a separate PR (which timed out and is rebuilding now).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2123
Implement proxy support for the Java HTTP client by "translating" the proxy
information specified in
HttpClientHandler.Proxyto the format accepted andexpected by the Java client. Since the translation may involve a DNS lookup, it
is performed in a separate task. No caching is attempted in our client code.