Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't propagate the Authorization header on redirect #2388

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Don't propagate the Authorization header on redirect #2388

merged 1 commit into from
Nov 7, 2018

Conversation

grendello
Copy link
Contributor

Fixes: #1924

The Authorization HTTP header should not be passed on to the next location
when redirecting. Make sure it is removed before following the redirect.

@grendello
Don't propagate the Authorization header on redirect
5126b83 
Fixes: dotnet#1924

The `Authorization` HTTP header should not be passed on to the next location
when redirecting. Make sure it is removed before following the redirect.
@grendello
Copy link
Contributor Author 

21:26:44   Test Run Summary
21:26:44     Overall result: Warning
21:26:44     Test Count: 629, Passed: 628, Failed: 0, Warnings: 0, Inconclusive: 0, Skipped: 1
21:26:44       Skipped Tests - Ignored: 1, Explicit: 0, Other: 0
21:26:44     Start time: 2018-11-05 21:26:40Z
21:26:44       End time: 2018-11-05 21:27:01Z
21:26:44       Duration: 21.432 seconds
21:26:44   
21:26:44   Results (nunit2) saved as TestResult-Java.Interop-Tests.xml
00:26:44 Build timed out (after 180 minutes). Marking the build as aborted.
00:26:44 make: *** [run-all-tests] Terminated: 15
00:26:44 + status=1
00:26:44 + make package-test-errors
00:26:44 Build was aborted

:(

@grendello grendello mentioned this pull request Nov 6, 2018
Merged
@grendello grendello requested a review from jonpryor November 6, 2018 10:01
@jonpryor jonpryor merged commit 376bfa1 into dotnet:master Nov 7, 2018
@grendello grendello deleted the issue1924 branch November 8, 2018 08:12
@bholmes bholmes added vs-sync For internal use only; creates a VSTS "mirror" issue. and removed vs-sync For internal use only; creates a VSTS "mirror" issue. labels Nov 29, 2018
jonpryor pushed a commit that referenced this pull request Nov 29, 2018
@grendello @jonpryor
[Mono.Android] Don't propagate the Authorization header on redirect (#…
c0813c5 
…2388)

Fixes: #1924

The `Authorization` HTTP header should not be passed on to the next
location when redirecting.

Make sure it is removed before following the redirect.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grendello @jonpryor @bholmes