[Xamarin.Android.Build.Tasks] Make Proguard mapping.txt opt-in #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#5304 The Proguard mapping.txt PR was not quite ready for prime time and has seemingly caused some new proguard test failures and an .apk size regression in our Xamarin.Forms baseline. Let's disable this by default for now until we can fix these issues.
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs
Outdated
Show resolved
Hide resolved
dellis1972
approved these changes
Nov 19, 2020
jonathanpeppers
approved these changes
Nov 19, 2020
|
The designer is failing on NuGet restore, but I think we can merge without this check. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5304
The Proguard mapping.txt PR was not quite ready for prime time and has
seemingly caused some new proguard test failures and an .apk size
regression in our Xamarin.Forms baseline. Let's disable this by default
for now until we can fix these issues.