-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xamarin.Android.Build.Tasks] Make manifestmerger.jar the default. #8392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context dotnet#8387 The value for `AndroidManifestMerger` should be updated to be `manifestmerger.jar`. This allows users to make use of the new features like `AndroidManifestOverlay` out of the box. The old system is still available, the users will need to add the following to their csproj. ``` <AndroidManifestMerger>legacy</AndroidManifestMerger> ```
6e4533b
to
2eee3b4
Compare
Use XML formatting.
jonathanpeppers
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth mentioning somewhere in the final commit message that AndroidX NuGets have been doing this for some time:
I don't think parts of AndroidX would even work without this. Should be fine to do in our .targets
, too.
jonathanpeppers
pushed a commit
that referenced
this pull request
Oct 10, 2023
…8392) Context: #8387 Context: 2c6f5cd Context: f7ea4a3 Context: d794534 Update the value for `$(AndroidManifestMerger)` (f7ea4a3) to `manifestmerger.jar`. This allows users to make use of the new features like `@(AndroidManifestOverlay)` (d794534) out of the box. The old system is still available, users will need to add the following to their csproj: <AndroidManifestMerger>legacy</AndroidManifestMerger> AndroidX has been building with `$(AndroidManifestMerger)`=manifestmerger.jar for [over three years][0]. [0]: xamarin/AndroidX@c6c0e50
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Oct 10, 2023
* main: [Xamarin.Android.Build.Tasks] Add support for $(AndroidEnableObsoleteOverrideInheritance). (dotnet#8393) [Xamarin.Android.Build.Tasks] Make manifestmerger.jar the default. (dotnet#8392)
jonathanpeppers
pushed a commit
that referenced
this pull request
Oct 17, 2023
…8392) Context: #8387 Context: 2c6f5cd Context: f7ea4a3 Context: d794534 Update the value for `$(AndroidManifestMerger)` (f7ea4a3) to `manifestmerger.jar`. This allows users to make use of the new features like `@(AndroidManifestOverlay)` (d794534) out of the box. The old system is still available, users will need to add the following to their csproj: <AndroidManifestMerger>legacy</AndroidManifestMerger> AndroidX has been building with `$(AndroidManifestMerger)`=manifestmerger.jar for [over three years][0]. [0]: xamarin/AndroidX@c6c0e50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #8387
The value for
AndroidManifestMerger
should be updated to bemanifestmerger.jar
. This allows users to make use of the new features likeAndroidManifestOverlay
out of the box.The old system is still available, the users will need to add the following to their csproj.