Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-dependencies with --channel and --repo does not correctly update coherency #3447

Closed
1 of 3 tasks
mmitche opened this issue Mar 25, 2024 · 0 comments · Fixed by #3448
Closed
1 of 3 tasks

Update-dependencies with --channel and --repo does not correctly update coherency #3447

mmitche opened this issue Mar 25, 2024 · 0 comments · Fixed by #3448

Comments

@mmitche
Copy link
Member

mmitche commented Mar 25, 2024

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

When running update-dependencies with --channel and --repo, coherency is missed. darc does claim that coherency updates are being done, but then nothing happens.

Release Note Description

Running update-dependencies with --channel and --repo now correctly updates coherency.

mmitche added a commit to mmitche/arcade-services that referenced this issue Mar 25, 2024
Fixes dotnet#3447
Before, coherency was only updated along two paths in update-dependencies, and the set of dependencies fed to the coherency check was not the full set of repo dependencies. This meant that in some invocations, dependencies would be updated without corresponding coherency updates. Instead, always update coherency, and always pass the full set of dependencies to the coherency calc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant