Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate cross/build-rootfs.sh into 1 place #53

Closed
eerhardt opened this issue Mar 9, 2018 · 10 comments
Closed

Consolidate cross/build-rootfs.sh into 1 place #53

eerhardt opened this issue Mar 9, 2018 · 10 comments
Assignees

Comments

@eerhardt
Copy link
Member

eerhardt commented Mar 9, 2018

In order to build arm binaries, we currently have roughly the same script copied into the following places:

https://github.com/dotnet/coreclr/blob/master/cross/build-rootfs.sh
https://github.com/dotnet/corefx/blob/master/cross/build-rootfs.sh
https://github.com/dotnet/core-setup/blob/master/cross/build-rootfs.sh

And they are all slightly out of date with each other because someone will update coreclr for a new platform or to fix a bug, and then forget to update the other duplicates.

Also, if/when ASP.NET and the SDK need to build for arm, they will need these scripts as well.

We should consolidate this infrastructure into a single place - this repo - where the things that are common across repos should live.

/cc @weshaggard @janvorli

@janvorli
Copy link
Member

janvorli commented Mar 9, 2018

Unifying them would also enable me to have a single crossfs and not a separate one for corefx, coreclr and core-setup.

@markwilkie
Copy link
Member

create native build epic

@markwilkie
Copy link
Member

It'd be good to be opportunistic here. (not blocking though)

@deinok
Copy link

deinok commented Oct 16, 2018

@eerhardt core-rt and source-build also use the cross folder. Just to no notice.
Is this up for grabs?

@deinok
Copy link

deinok commented Oct 19, 2018

@janvorli About the cross folder.

I'm new to arcade, but I supose that what you need is a Task (https://docs.microsoft.com/en-us/dotnet/api/microsoft.build.utilities.task?view=netframework-4.7.2) that implements all the things from the cross folder, I'm right?

@jcagme
Copy link
Contributor

jcagme commented Oct 22, 2018

Don't know anything about this script but given that corefx, coreclr, core-setup and most likely aspnet are/will consuming this, I think this is a good candidate for eng/common. We could create a cross folder and copy a version there. Don't know if at this point all repos have the same version or what would determine which is to be moved but we would end up with something like eng/common/cross/build-rootfs.sh.

@weshaggard thoughts?

@weshaggard
Copy link
Member

Yes I agree we should try and share this script under eng\common.

@jcagme
Copy link
Contributor

jcagme commented Oct 22, 2018

What repo should we use to get the file from?

@deinok
Copy link

deinok commented Oct 23, 2018

I'm not sure but I think coreclr

@janvorli
Copy link
Member

Yes, coreclr is the right source. But it is not just the build-rootfs.sh. We need to share the whole cross folder contents except of the tryrun.cmake which is repo specific.

@jcagme jcagme self-assigned this Oct 23, 2018
ViktorHofer pushed a commit to ViktorHofer/arcade that referenced this issue Oct 25, 2023
Add an `EnsureAllResourcesTranslated` task and target that verifies all `trans-unit` items are in a `translated` state. If not, MSBuild errors are logged, failing the build.

Fixes dotnet#53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants