Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast up-to-date check for VSIX projects #14764

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sharwell
Copy link
Member

No description provided.

<!--
Make sure to include information about inputs and outputs to CreateVsixContainer for fast up-to-date check.
-->
<PropertyGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this rather be in the VS SDK? Doesn't seem specific to Arcade VSIX customizations. Wouldn't other VSSDK customers benefit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me what the relation is between the VSSDK targets and Arcade. The VSSDK should definitely update to support FUTDC, but it seems like a slower roll-out time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine updating Arcade to have this as long as we link to an issue that tracks the work to fix it in VSSDK.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekoppel it looks like you are currently maintaining the VS SDK side of this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging PR to improve dev inner loop. Please open a tracking item for vs sdk as a follow up though.

@sharwell sharwell marked this pull request as ready for review May 29, 2024 13:20
@arkalyanms
Copy link
Member

Safe to merge this now?

@arkalyanms arkalyanms merged commit 5031801 into dotnet:main Jun 11, 2024
11 checks passed
@sharwell sharwell deleted the vsix-up-to-date branch June 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants