Update signtool plan #453
Merged
Update signtool plan #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing to always generate manifest during build to reflect the decision that happened recently in #58
JohnTortugo
reviewed
Aug 9, 2018
| @@ -16,7 +15,7 @@ that the binaries were actually signed. | |||
| 3. (S138) Arcade should sign its packages using the SignTool that is in the SDK. | |||
| 4. (S138 - S139) Refactor the SignTool to accomodate scenarios for other repositories. Examples of the changes are: | |||
| - Convert to MsBuild task. | |||
| - Accept a manifest file from different source (implicit or explicit). | |||
| - Generate a manifest file during the build. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JohnTortugo
reviewed
Aug 9, 2018
| @@ -5,8 +5,7 @@ The goal of the signing plan is to provide guidance on how the tier 1 (T1) produ | |||
| - Leverage pre-existing solutions so that work isn't duplicated. | |||
| - Where possible, avoid dependency on software installed on the machine to facilitate the consumtion of the tool accross the .NET Core repositories. | |||
| - The consumption method of the SignTool should follow the [Methods for Consuming the .NET Core Shared Infrastructure Components](https://github.com/dotnet/arcade/blob/master/Documentation/Overview.md#methods-for-consuming-the-net-core-shared-infrastructure-components). | |||
| - Signtool will need a manifest (list of files) in order to know what to sign. The manifest can be checked in (explicit) or | |||
| can be generated during the build (implicit). | |||
| - Signtool will need a manifest (list of files) in order to know what to sign. The manifest will be generated during the build (implicit). | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JohnTortugo
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing to always generate manifest during build to reflect the decision that happened recently in #58