-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New publishing infrastructure documentation #4556
Conversation
Super happy this exists! |
Aside from my comment about the differences section, this LGTM. Let's get someone else from the team that isn't involved in the infra to take a look with fresh eyes. That usually catches places where we have made assumptions that new people onboarding might not understand. |
Thanks @JohnTortugo ! A few high level comments:
Regardless, this looks quite complete. Thanks Cesar! |
I think those are all good suggestions Mark. I changed the text to incorporate them. Thanks! |
@riarenas @markwilkie - I think the doc is in much better shape now. Thanks for the suggestions. @jcagme @adiaaida @garath @sunandabalu @mjanecke @MattGal @jonfortescue - PTAL if you have some time. I could benefit from a reviewer not so familiar with the work done. |
FAQ section is very helpful 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Like the FAQ section, and the tutorial appears to be fairly easy for someone to set up. Nice work :)
Co-Authored-By: Ricardo Arenas <riarenas@microsoft.com>
Co-Authored-By: Ricardo Arenas <riarenas@microsoft.com>
@markwilkie are you good to merge this? |
I just realized there's something we should probably add to this doc: A description of the purpose for each of the artifact types that we use: PackageArtifacts, BlobArtifacts, PdbArtifacts etc. |
Done. @markwilkie - can you please merge this? I don't have permission to do it. |
Closes: #3599
Removed documentation about the old infrastructure and updated documentation about YAML Stages based publishing.