Optional Download artifacts parameter #5158
Conversation
|
NIT: Will anything work if the artifacts aren't downloaded? Can't they just disable the SDL validation? |
|
This is #5149. Runtime repo wants to enable policheck. This is a tool that runs on source code and not artifacts, so it should be fine for that particular tool. This looks OK to me in that you need to specifically opt out of downloading the artifacts, but it's a little scary in that it will break if they ever just want to add a tool that runs on the artifacts, as it's just a change in a variable group and might start breaking builds without any changes to their branch YAML, so it'll be really confusing. |
|
I also don't know if we can look into the parameters that they provide to determine if they are running any artifacts based tools, and then warn about that so people are not surprised when it fails if they opted out of downloading assets? |
Yes the artifact download is needed only for tools that run on artifacts, currently everyone is only running tools on source code. so having the ability to turn off artifact downloads def saves time. The extract step already has code in place to do nothing if the artifact folder is empty. |
Teams are setting the tools to run in the yaml directly, the only thing that is in the variable group is the user specific settings like area path, codebase admin coz every team has turned on the exact tools we asked them to :D So adding a artifacts based tool would require a PR to the yaml as of now but there is nothing stopping people to move this to the variable group as well. |
To turn on tools running on artifacts is a separate parameter than the source-based one, so we can easily figure out if any artifact based tools have been added. |
|
@AlitzelMendez Please run test build
|
…lstudio.com/internal/_git/dotnet-arcade into almend/SLDOptionalDownloadArti
|
Hi @sunandabalu I changed a little bit the logic so always run unless the contrary be specified, sharing with you the test:
in order to run this test I also included some changed in post-build.yml, as we don't want to change this in our build (pass that value) I am not sure if we need to include those changes. |
@AlitzelMendez What did you have to change in post-build.yml? |
The tests looks like are doing the right thing, thanks for running them. |
|
@sunandabalu do you think that this change is ready to merge or needs more testing? or any change? |
you mentioned you changed something in post-build.yml to get the tests running, what was the change you had to make? |
|
Hi @sunandabalu |
Doing this change as a short term fix to unblock runtime to enable SDL runs.