Update links from accountname.visualstudio.com to dev.azure.com/accountname #773
Conversation
eng/Versions.props
Outdated
| @@ -1,62 +1,62 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Do we need to update https://github.com/dotnet/arcade/blob/master/eng/common/templates/phases/base.yml#L67? |
|
@jcagme , the path for connecting to a package feed has not changed from the old format (at least according to the link Azure DevOps gives you when you navigate to "Artifacts"). |
| <_Replacement>https://github.com/$1/$2</_Replacement> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <ScmRepositoryUrl>$([System.Text.RegularExpressions.Regex]::Replace($(ScmRepositoryUrl), $(_Pattern), $(_Replacement)))</ScmRepositoryUrl> | ||
| <ScmRepositoryUrl>$([System.Text.RegularExpressions.Regex]::Replace($(ScmRepositoryUrl), $(_VstsPattern), $(_Replacement)))</ScmRepositoryUrl> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -19,17 +19,17 @@ | |||
|
|
|||
| <!-- The convention for names of VSTS repositories mirrored from GitHub is "{GitHub org name}-{GitHub repository name}" --> | |||
| <PropertyGroup> | |||
| <_Pattern>https://dnceng.visualstudio.com/internal/_git/([^/-]+)-(.+)</_Pattern> | |||
| <_Pattern>https://[^\.]+\.visualstudio\.com/[^/]+/_git/([^/-]+)-(.+)|https://dev.azure.com/[^/]+/[^/]+/_git/([^/-]+)-(.+)</_Pattern> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
FYI @vtbassmatt |
|
I'm going to merge this tomorrow morning (9/18) unless there's additional feedback. |
|
Re: the package URLs, you should get the new domain if you hit the web UI via the new domain. I wouldn't let that block you for now, though. LGTM. |
Mostly just doc updates, but...
@jcagme @alexperovich , can you pay particular attention to the Darc source code changes?
@tmat, can you double check the update to RepositoryInfo.targets?
FYI @mmitche @