Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of Navigation Menu Consistency #1031

Closed

Conversation

josephaw1022
Copy link

Upon reviewing the existing navigation menu implementation, it became apparent that the design consistency and user experience were not aligned with established patterns, especially when compared to the navigation menu utilized within Azure DevOps. The visual cohesion and functional clarity present in the DevOps menu, as depicted in the reference image below, served as an inspiration for the proposed enhancements.

Reference Image from Azure DevOps:

image

To address this, I have repositioned the settings button and the sidebar toggle to the lower end of the navigation menu, emulating the intuitive layout found in DevOps. The current structure of the NavMenuLink component presents certain constraints that prevent the combination of multiple icons within a single button or row. Nevertheless, I managed to circumvent this limitation by introducing two distinct buttons at the bottom of the menu. This adjustment has resulted in a more streamlined and user-friendly navigation interface.

Here is the new interface:

NavMenu Expanded:

image

NavMenu Closed:

image

@josephaw1022 josephaw1022 changed the title Enhancement of Navigation Menu Consistency and Usability Enhancement of Navigation Menu Consistency Nov 24, 2023
@davidfowl
Copy link
Member

I like this. Especially for smaller laptop screens.

@vnbaaij
Copy link
Contributor

vnbaaij commented Nov 24, 2023

I like it too, however... The NavMenu has a Collapsible parameter to enable showing a hamburger at the top. Think this location is more common (also shown in that position in ADO) so would suggest to change the PR to do that.

@tlmii
Copy link
Member

tlmii commented Nov 24, 2023

Agree with Vincent on the hamburger menu. I have no problem with the settings being at the bottom of the menu. In fact, that was part of my original design. At the time the menu couldn't really stretch to the height of the viewport and I got some feedback that people wanted the settings button top-right anyway so we went the other way. We have since changed the page structure so the menu can stretch now, so this is nice. I would just make sure we get design consensus given the feedback I got originally. @leslierichardson95 @kvenkatrajan.

@josephaw1022
Copy link
Author

josephaw1022 commented Nov 24, 2023

To provide a clearer comparison and facilitate decision-making, I've compiled a few layout options for the navigation menu. This visual representation should help in evaluating the most effective design choice.

Original Layout:
Here's how our navigation menu currently looks:
Original Layout

Proposed Change: Toggle Sidebar and Settings at Bottom:
This is the layout I am suggesting, with the toggle for the sidebar and the settings button placed at the bottom:
Toggle Sidebar and Settings at Bottom

Alternative Option: Toggle Sidebar at Both Top and Bottom with Settings at Bottom:
In this layout, the sidebar toggle is available at both the top and bottom, with the settings button still at the bottom:
Toggle Sidebar at Bottom and Top with Settings at Bottom

Suggested Variation: Menu at Top and Settings at Bottom: (What I assume @vnbaaij has in mind from the initial feedback)
And finally, this layout features the menu at the top with the settings at the bottom:
Menu at Top and Settings at Bottom

@josephaw1022
Copy link
Author

made changes and re-added the menu on the top. No other changes needed?

@mitchdenny
Copy link
Member

Funnily enough I think what we have now is closer to the Azure DevOps experience. Even though we have a Settings panel, the Aspire dashboard, when we consider the content, its more like the user settings which are indeed in the top right corner:

image

@tlmii
Copy link
Member

tlmii commented Nov 27, 2023

FWIW, the Azure Portal has it in the top right too (along with a whole host of other stuff):
image

@josephaw1022
Copy link
Author

josephaw1022 commented Nov 27, 2023

That is true. But, is the settings only going to be just a "wrapper" (couldn't think of a better word) around the ui theme? Because if there are other things that will in the settings sidebar or dialog, then having the settings button and a separate theme button would make sense in this context right?

@josephaw1022
Copy link
Author

josephaw1022 commented Nov 27, 2023

Funnily enough I think what we have now is closer to the Azure DevOps experience. Even though we have a Settings panel, the Aspire dashboard, when we consider the content, its more like the user settings which are indeed in the top right corner:

image

Good eye. I didn't even notice that initially.

@leslierichardson95
Copy link

While I understand the reasoning for each argument, I personally prefer Settings to be displayed up top. Plus, as we expand the dashboard with more features and user options, having a settings dropdown feels more organic on top than it would in the side bar. That said, this UI change feels pretty arbitrary overall and I think we could just leave Settings as-is until more people request the alternative(s).

@kvenkatrajan
Copy link
Member

Agreed while I see the bottom Settings display (in addition to the top right) being a discoverable option (especailly for smaller screen size), given the limited options we have in settings at the moment makes sense to leave it as is and revisit later.

@samsp-msft
Copy link
Member

The diagrams above also seemed to imply a collapsing of Projects / Containers / Executables. Is that also in the plan?

@kvenkatrajan
Copy link
Member

Yes that's correct. It was done in a prior PR merged recently : #987

@joperezr joperezr added the community-contribution Indicates that the PR has been added by a community member label Dec 11, 2023
@kvenkatrajan
Copy link
Member

We have had numerous changes in the UI. Please confirm if this addresses your initial feedback/issue

@davidfowl
Copy link
Member

Closing this PR out, it's old and many changes have been made to the dashboard since then. @josephaw1022 Thanks for the awesome early contribution and inspiration.

@davidfowl davidfowl closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dashboard community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants