-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of Navigation Menu Consistency #1031
Conversation
I like this. Especially for smaller laptop screens. |
I like it too, however... The NavMenu has a Collapsible parameter to enable showing a hamburger at the top. Think this location is more common (also shown in that position in ADO) so would suggest to change the PR to do that. |
Agree with Vincent on the hamburger menu. I have no problem with the settings being at the bottom of the menu. In fact, that was part of my original design. At the time the menu couldn't really stretch to the height of the viewport and I got some feedback that people wanted the settings button top-right anyway so we went the other way. We have since changed the page structure so the menu can stretch now, so this is nice. I would just make sure we get design consensus given the feedback I got originally. @leslierichardson95 @kvenkatrajan. |
To provide a clearer comparison and facilitate decision-making, I've compiled a few layout options for the navigation menu. This visual representation should help in evaluating the most effective design choice. Original Layout: Proposed Change: Toggle Sidebar and Settings at Bottom: Alternative Option: Toggle Sidebar at Both Top and Bottom with Settings at Bottom: Suggested Variation: Menu at Top and Settings at Bottom: (What I assume @vnbaaij has in mind from the initial feedback) |
made changes and re-added the menu on the top. No other changes needed? |
That is true. But, is the settings only going to be just a "wrapper" (couldn't think of a better word) around the ui theme? Because if there are other things that will in the settings sidebar or dialog, then having the settings button and a separate theme button would make sense in this context right? |
While I understand the reasoning for each argument, I personally prefer Settings to be displayed up top. Plus, as we expand the dashboard with more features and user options, having a settings dropdown feels more organic on top than it would in the side bar. That said, this UI change feels pretty arbitrary overall and I think we could just leave Settings as-is until more people request the alternative(s). |
Agreed while I see the bottom Settings display (in addition to the top right) being a discoverable option (especailly for smaller screen size), given the limited options we have in settings at the moment makes sense to leave it as is and revisit later. |
The diagrams above also seemed to imply a collapsing of Projects / Containers / Executables. Is that also in the plan? |
Yes that's correct. It was done in a prior PR merged recently : #987 |
We have had numerous changes in the UI. Please confirm if this addresses your initial feedback/issue |
Closing this PR out, it's old and many changes have been made to the dashboard since then. @josephaw1022 Thanks for the awesome early contribution and inspiration. |
Upon reviewing the existing navigation menu implementation, it became apparent that the design consistency and user experience were not aligned with established patterns, especially when compared to the navigation menu utilized within Azure DevOps. The visual cohesion and functional clarity present in the DevOps menu, as depicted in the reference image below, served as an inspiration for the proposed enhancements.
Reference Image from Azure DevOps:
To address this, I have repositioned the settings button and the sidebar toggle to the lower end of the navigation menu, emulating the intuitive layout found in DevOps. The current structure of the
NavMenuLink
component presents certain constraints that prevent the combination of multiple icons within a single button or row. Nevertheless, I managed to circumvent this limitation by introducing two distinct buttons at the bottom of the menu. This adjustment has resulted in a more streamlined and user-friendly navigation interface.Here is the new interface:
NavMenu Expanded:
NavMenu Closed: