[release/8.0-preview3] Remove resource and endpoint name validation #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
|
Verified this change worked in the Aspire repo:
|
joperezr
approved these changes
Feb 6, 2024
davidfowl
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2083
This reverts the change to validate a project name must be ASCII text, numbers or dashes. Dots and underscores are allowed.
It keeps the change introduced that names are case insensitive. That change touched more places so I've left it in to make this PR as conservative as possible. i.e. if you have two resources: MYDATABASE and mydatabase then there will be a conflict and an error is thrown.
Microsoft Reviewers: Open in CodeFlow