Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display new error logs count to projects page #545

Merged
merged 8 commits into from
Oct 28, 2023
Merged

Display new error logs count to projects page #545

merged 8 commits into from
Oct 28, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 27, 2023 •
edited
Loading

Addresses #533

log-unread-count

@davidfowl
Copy link
Member

@JamesNK does this also do executables?

@JamesNK JamesNK force-pushed the jamesnk/display-unread-error-count branch from 31d3a3e to 7d27fda Compare October 28, 2023 07:45
@JamesNK JamesNK force-pushed the jamesnk/display-unread-error-count branch from 7d27fda to 87d1cf0 Compare October 28, 2023 07:46
@JamesNK
Copy link
Member Author

JamesNK commented Oct 28, 2023

@JamesNK does this also do executables?

I've updated the PR to support projects, containers and executables.

davidfowl
davidfowl reviewed Oct 28, 2023
View reviewed changes
src/Aspire.Dashboard/Otlp/Storage/TelemetryRepository.cs

try
{
return _applicationUnviewedErrorLogs.ToDictionary();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf.... 😄

davidfowl
davidfowl approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This performance of this code doesn't look great, but it'll be fine for preview.

@JamesNK JamesNK merged commit 4032b57 into main Oct 28, 2023
4 checks passed
@JamesNK JamesNK deleted the jamesnk/display-unread-error-count branch October 28, 2023 12:55
@JamesNK JamesNK mentioned this pull request Nov 11, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@smitpatel smitpatel Awaiting requested review from smitpatel

@tlmii tlmii Awaiting requested review from tlmii

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesNK @davidfowl @danmoseley