Fix HttpHeaders Keys case sensitivity (#50606)

dotnet · Sep 11, 2023 · 4365561 · 4365561
1 parent 6f668d8
commit 4365561
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs
@@ -115,7 +115,7 @@ protected static void ThrowDuplicateKeyException()
 
     bool ICollection<KeyValuePair<string, StringValues>>.IsReadOnly => _isReadOnly;
 
-    ICollection<string> IDictionary<string, StringValues>.Keys => ((IDictionary<string, StringValues>)this).Select(pair => pair.Key).ToList();
+    ICollection<string> IDictionary<string, StringValues>.Keys => ((IDictionary<string, StringValues>)this).Select(pair => pair.Key).ToHashSet(StringComparer.OrdinalIgnoreCase);
 
     ICollection<StringValues> IDictionary<string, StringValues>.Values => ((IDictionary<string, StringValues>)this).Select(pair => pair.Value).ToList();
 

diff --git a/src/Servers/Kestrel/Core/test/HttpHeadersTests.cs b/src/Servers/Kestrel/Core/test/HttpHeadersTests.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http;
 using Microsoft.Extensions.Primitives;
 using Microsoft.Net.Http.Headers;
@@ -298,4 +299,12 @@ private static void InvalidContentLengthsRejectedImpl(HttpHeaders httpHeaders)
         Assert.Null(httpHeaders.ContentLength);
         Assert.False(httpHeaders.ContentLength.HasValue);
     }
+
+    [Fact]
+    public void KeysCompareShouldBeCaseInsensitive()
+    {
+        var httpHeaders = (IHeaderDictionary)new HttpRequestHeaders();
+        httpHeaders["Cache-Control"] = "no-cache";
+        Assert.True(httpHeaders.Keys.Contains("cache-control"));
+    }
 }