Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HttpHeaders Keys #50606

Merged
merged 3 commits into from Sep 11, 2023
Merged

Update HttpHeaders Keys #50606

merged 3 commits into from Sep 11, 2023

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Sep 9, 2023 •
edited

Update HttpHeaders Keys to use a case-insensitive comparer

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Use .ToHashSet(StringComparer.OrdinalIgnoreCase) to implement case-insensitive comparer

Fixes #50553

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 9, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2023
@ghost
Copy link

ghost commented Sep 9, 2023

Thanks for your PR, @WeihanLi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@WeihanLi WeihanLi marked this pull request as ready for review September 9, 2023 14:14
@WeihanLi
Copy link
Contributor Author

WeihanLi commented Sep 9, 2023

Seemed the failed test case is not related
image

@Tratcher Tratcher self-assigned this Sep 11, 2023
@Tratcher Tratcher enabled auto-merge (squash) September 11, 2023 15:58
@Tratcher Tratcher merged commit 4365561 into dotnet:main Sep 11, 2023
26 checks passed
@ghost ghost added this to the 9.0-preview1 milestone Sep 11, 2023
@WeihanLi WeihanLi deleted the patch-1 branch September 12, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.

HttpRequestHeaders Keys.Contains is not case insensitive, whereas HttpDictionary is
2 participants
@WeihanLi @Tratcher