Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API baselines after 5.0 merge #27963

Closed
wants to merge 2 commits into from
Closed

Fix API baselines after 5.0 merge #27963

wants to merge 2 commits into from

Conversation

JunTaoLuo
Copy link
Contributor

I removed APIs from Shipped if a new one replaced the old one. The proper way of doing this is to add the API to Unshipped and add a REMOVED prefix. This PR fixes this merge mistake.

@JunTaoLuo JunTaoLuo requested review from dougbu and a team November 18, 2020 21:14
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 18, 2020
@JunTaoLuo
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@JunTaoLuo
Copy link
Contributor Author

ping @dougbu

dougbu
dougbu requested changes Nov 19, 2020
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is way too large. Just need to restore the lines shown by

git diff release/5.0..master -- **/PublicAPI.Shipped.txt

then add *REMOVED* to the restored lines.

@JunTaoLuo JunTaoLuo mentioned this pull request Nov 30, 2020
Merged
4 tasks
@Tratcher Tratcher removed their request for review December 8, 2020 01:07
Base automatically changed from master to main January 22, 2021 01:33
@dougbu dougbu requested a review from a team as a code owner January 22, 2021 01:33
@JunTaoLuo
Copy link
Contributor Author

Superseded by #28253

@JunTaoLuo JunTaoLuo closed this Feb 4, 2021
@dougbu dougbu deleted the johluo/apibaseline-fixup branch August 21, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu requested changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@jkotalik jkotalik Awaiting requested review from jkotalik

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunTaoLuo @dougbu @Pilchie