[AuthZ] Switch to debug logging to cut down on noise #29137
Conversation
ghost
added
the
HaoK
changed the title
| formatString: "Authorization was successful."); | ||
| _userAuthorizationFailed = LoggerMessage.Define<string>( | ||
| eventId: new EventId(2, "UserAuthorizationFailed"), | ||
| logLevel: LogLevel.Information, | ||
| logLevel: LogLevel.Debug, | ||
| formatString: "Authorization failed. {0}"); |
There was a problem hiding this comment.
The failure scenario seems to be providing more data than they reported in the issue. Looks like that was a 5.0 change?
If the failure case is providing useful details now then we should keep that at the existing log level.
There was a problem hiding this comment.
It depends on the code path really, but sure we can keep the failure as Information and the success as Debug, thoughts @blowdart ? There's potentially more information if requirements failed as opposed to explicit Fail being called
There was a problem hiding this comment.
Darn it. Ok yes, keep fail as informational then.
|
Hello @HaoK! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
For #28234