[SignalR TS] Set keep alive timer in receive loop (#31300) #31627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
BrennanConroy
added
Servicing-approved
|
Tactics approved over email. |
halter73
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome released a timer throttling feature that causes SignalR clients to disconnect a few minutes after the browser tab becomes inactive. If you start a timer from a network callback then the throttling does not occur. So we changed how we use timers to only be started from a network event.
Customer Impact
SignalR clients will disconnect a few minutes after the browser tab becomes inactive. This is undesired behavior for users of SignalR.
Regression?
Risk
The fix has been tested by internal and external people.
Verification
Packaging changes reviewed?
Addresses #31079