Pass in IFormFileCollection into minimal hosting delegate #35100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-runtime
community-contribution
|
This adds support for IFormFileCollection but what about IFormFile? |
|
Didn't quite know what the nameof would be for the first item in the
collection
…On Fri, 6 Aug 2021 at 12:17, David Fowler ***@***.***> wrote:
This adds support for IFormFileCollection but what about IFormFile?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZVJQFPAEZ7NQUK2LP6D3T3PAEZANCNFSM5BVWHPOA>
.
|
davidfowl
reviewed
Aug 6, 2021
| @@ -55,6 +55,7 @@ public static partial class RequestDelegateFactory | |||
| private static readonly MemberExpression HttpResponseExpr = Expression.Property(HttpContextExpr, nameof(HttpContext.Response)); | |||
| private static readonly MemberExpression RequestAbortedExpr = Expression.Property(HttpContextExpr, nameof(HttpContext.RequestAborted)); | |||
| private static readonly MemberExpression UserExpr = Expression.Property(HttpContextExpr, nameof(HttpContext.User)); | |||
| private static readonly MemberExpression FormFileExpr = Expression.Property(HttpContextExpr, nameof(HttpContext.Request.Form.Files)); | |||
There was a problem hiding this comment.
This isn't how we would do this. Reading the form body should be done asynchronously. We'd probably store state on the FactoryContext that describes this is a form body that needs files. Take a look at BindParameterFromBody and HandleRequestBodyAndCompileRequestDelegate
|
This change is a bit more complex than what's implemented here:
|
6 tasks
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds IFormFileCollection IFormFileCollection into minimal hosting delegate.
Fixes #34303
NOTE: Tests not added as cannot get any IDE to work so happy for someone to take this commit and carry on the work