Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Playwright #38414

Merged
merged 41 commits into from
Jan 12, 2022
Merged

Upgrade Playwright #38414

merged 41 commits into from
Jan 12, 2022

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Nov 15, 2021 •
edited
Loading

This is used within the Blazor Template Tests.

Contributes towards #30882.

Note, the goal of this PR is just to get the underlying Playwright upgraded from the pre-release version, to the latest stable release. The underlying tests are unchanged by this PR.

@TanayParikh TanayParikh requested a review from a team as a code owner November 15, 2021 20:53
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2021
@TanayParikh TanayParikh marked this pull request as draft November 15, 2021 20:55
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Nov 15, 2021 •
edited
Loading

Converting to draft. Nuget hasn't been updated in 8 months and it's stuck on 0.192.0 (https://www.nuget.org/packages/playwright-sharp-tool), while the GitHub repo is on 1.16.1 (https://github.com/microsoft/playwright-dotnet/tags). Investigating upgrade.

Created: microsoft/playwright-dotnet#1829

Update: The playwright-sharp-tool has been deprecated and replaced with Microsoft.Playwright

@TanayParikh TanayParikh removed request for a team and javiercn November 15, 2021 20:56
@TanayParikh TanayParikh changed the title Upgrade playwright-sharp-tool Upgrade playwright-sharp Nov 15, 2021
@TanayParikh TanayParikh changed the title Upgrade playwright-sharp Upgrade Playwright Nov 15, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 15, 2021
@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@adrianwright109
Copy link
Contributor

@TanayParikh FYI: I just looked on the GitHub Repo https://github.com/microsoft/playwright-dotnet and saw that version 1.12.1 which was the next version after 0.192.0 was a major release and includes many breaking changes. See release notes for more details: https://github.com/microsoft/playwright-dotnet/releases/tag/v1.12.1

@TanayParikh TanayParikh added the area-blazor Includes: Blazor, Razor Components label Nov 16, 2021
TanayParikh
TanayParikh commented Nov 16, 2021
View reviewed changes
eng/helix/content/RunTests/TestRunner.cs
@@ -55,9 +55,6 @@ public bool SetupEnvironment()
var playwrightBrowsers = Environment.GetEnvironmentVariable("PLAYWRIGHT_BROWSERS_PATH");
Console.WriteLine($"Setting PLAYWRIGHT_BROWSERS_PATH: {playwrightBrowsers}");
EnvironmentVariables.Add("PLAYWRIGHT_BROWSERS_PATH", playwrightBrowsers);
var playrightDriver = Environment.GetEnvironmentVariable("PLAYWRIGHT_DRIVER_PATH");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be possible to specify driver path any longer:

https://github.com/microsoft/playwright-dotnet/blob/45de47f3f51c086278b347e09a878731d996e2e5/src/Playwright/Helpers/Paths.cs

@TanayParikh TanayParikh self-assigned this Nov 17, 2021
mxschmitt
mxschmitt approved these changes Jan 6, 2022
View reviewed changes
.azure/pipelines/ci.yml Outdated Show resolved Hide resolved
.azure/pipelines/quarantined-pr.yml Outdated Show resolved Hide resolved
eng/helix/content/RunTests/TestRunner.cs Outdated Show resolved Hide resolved
eng/helix/content/RunTests/TestRunner.cs Outdated Show resolved Hide resolved
src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs Outdated Show resolved Hide resolved
src/ProjectTemplates/BlazorTemplates.Tests/BlazorWasmTemplateTest.cs Outdated Show resolved Hide resolved
src/ProjectTemplates/BlazorTemplates.Tests/playwrightSettings.json Show resolved Hide resolved
@TanayParikh
Copy link
Contributor Author

/azp run

@TanayParikh
Copy link
Contributor Author

Needs a full re-run given #39361.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@TanayParikh
Copy link
Contributor Author

Thanks @mxschmitt, that was really helpful!

@TanayParikh TanayParikh marked this pull request as ready for review January 7, 2022 03:54
@TanayParikh TanayParikh requested a review from a team January 7, 2022 03:55
mxschmitt
mxschmitt approved these changes Jan 7, 2022
View reviewed changes
eng/helix/content/RunTests/TestRunner.cs Outdated Show resolved Hide resolved
@TanayParikh TanayParikh enabled auto-merge (squash) January 11, 2022 21:53
@TanayParikh TanayParikh merged commit 3129207 into main Jan 12, 2022
@TanayParikh TanayParikh deleted the taparik/upgradePlaywrightSharpTool branch January 12, 2022 00:21
@TanayParikh TanayParikh mentioned this pull request Dec 21, 2022
Closed
@wtgodbe wtgodbe mentioned this pull request Jul 2, 2024
Merged
11 tasks
MackinnonBuck pushed a commit that referenced this pull request Jul 9, 2024
@TanayParikh @MackinnonBuck
Upgrade Playwright
a45498a 
Cherry-pick of #38414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello left review comments

@javiercn javiercn javiercn approved these changes

@mxschmitt mxschmitt mxschmitt approved these changes

@dougbu dougbu Awaiting requested review from dougbu

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

@TanayParikh TanayParikh

Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TanayParikh @adrianwright109 @mxschmitt @martincostello @javiercn @mkArtakMSFT