Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Bump to macos-12 build image #56273

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 17, 2024

Backport of #56270 to release/6.0

/cc @akoeplinger

[release/8.0] Bump to macos-12 build image

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested a review from a team as a code owner June 17, 2024 16:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 6.0.x milestone Jun 17, 2024
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 17, 2024
@akoeplinger akoeplinger changed the title [release/6.0] [release/8.0] Bump to macos-12 build image [release/6.0] Bump to macos-12 build image Jun 19, 2024
@akoeplinger
Copy link
Member

The mac test failure is related:

Playwright does not support chromium on mac12

Looks like playwright needs to be updated too.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 26, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Jul 2, 2024

We updated playwright in newer branches w/ #38414, but that doesn't port cleanly here. I'll see if I can get someone to take a look

@mkArtakMSFT mkArtakMSFT merged commit 2e06155 into release/6.0 Jul 10, 2024
23 checks passed
@mkArtakMSFT mkArtakMSFT deleted the backport/pr-56270-to-release/6.0 branch July 10, 2024 18:37
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.33 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants