Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always build App.Ref and the targeting packs (subset) #39587

Closed
wants to merge 2 commits into from
Closed

Always build App.Ref and the targeting packs (subset) #39587

wants to merge 2 commits into from

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jan 17, 2022

@dougbu
Always build App.Ref and the targeting packs
0bcb79d 
- remove `$(IsTargetingPackBuilding)` entirely
@dougbu
Undo optional changes
4c8c661 
- subset of dotnet#39568
- set `$(IsTargetingPackBuilding)` to `true` unconditionally
- leave all _use_ of `$(IsTargetingPackBuilding)`
@dougbu dougbu mentioned this pull request Jan 17, 2022
Closed
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 18, 2022
@dougbu dougbu closed this Jan 19, 2022
@dougbu dougbu deleted the dougbu/istargetingpackbuilding.yes.39471.subset branch January 19, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @Pilchie