Fix nullability of TryUpdateModelAsync #41959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be source-breaking (especially since arrays and Expressions are not covariant), so we should make an announcement if we change this. That said, the nu.labilty was wrong before and we have generally decided to fix nullability mistakes.
https://github.com/dotnet/runtime/blob/8a043bf7adb0fbf5e60a8dd557c98686bc0a8377/docs/coding-guidelines/api-guidelines/nullability.md#breaking-change-guidance
Fixes #41886
This will also address the nullability fix described in #41929. We're keeping that open to track the breaking change announcements though.Edit: Just kidding. Our public API check complains of all of the following because the nullable setter has nothing in the annotation indicating it's nullable. So you have to leave it as-is or try "removing" and readding it in PublicAPI.Unshipped.txt. Neither works.
I'll submit a separate PR and see if we can force it through in PublicAPI.Shipped.txt or something.