-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL building for SPA proxying #43407
Fix URL building for SPA proxying #43407
Conversation
Thanks for your PR, @varsi94. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
…roxy-path-building
@MackinnonBuck please talk to Javier about this if you have any questions, and then review this PR. Thanks! |
Want to fix #43662 while you're at it? It's likely on the same line. |
src/Middleware/Spa/SpaServices.Extensions/src/Proxying/SpaProxy.cs
Outdated
Show resolved
Hide resolved
src/Middleware/Spa/SpaServices.Extensions/src/Proxying/SpaProxy.cs
Outdated
Show resolved
Hide resolved
@MackinnonBuck can you do some manual testing for both of these bugs? It doesn't look like there's any automated tests for this. |
I have added some, you can check. @MackinnonBuck @Tratcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just now getting to this - I have one piece of feedback but otherwise it looks great!
Thanks for your contribution @varsi94!
src/Middleware/Spa/SpaServices.Extensions/src/Proxying/SpaProxy.cs
Outdated
Show resolved
Hide resolved
… for empty PathString
…roxy-path-building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Fix URL building for SPA proxying
Fix URL building when proxying to a host where the SPA is not on the root URL
Description
If the SPA proxy is not listening on the root url (e.g. http://localhost:3000/spa), then the path segments are ignored when sending the request to the development server. This path segment is prepended to the URL, if there's any.
Fixes #31229