Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HttpLogging middleware endpoint aware #47595

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Make HttpLogging middleware endpoint aware #47595

merged 5 commits into from
Apr 21, 2023

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Apr 6, 2023

Addresses #43222

And fixes #46703 as it was preventing testing the response byte limit.

@amcasey
Copy link
Member

amcasey commented Apr 15, 2023

@BrennanConroy Good to go?

@JamesNK
Copy link
Member

JamesNK commented Apr 17, 2023

I believe there are analyzers for checking endpoint-aware middleware is between UseRouting and UseEndpoint. Should it be updated to check HttpLogging middleware position?

@BrennanConroy BrennanConroy merged commit b4811e3 into main Apr 21, 2023
26 checks passed
@BrennanConroy BrennanConroy deleted the brecon/httplog branch April 21, 2023 18:10
@ghost ghost added this to the 8.0-preview4 milestone Apr 21, 2023
@adityamandaleeka adityamandaleeka added the blog-candidate Consider mentioning this in the release blog post label May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

@BrennanConroy, this change will be considered for inclusion in the blog post for the release it'll ship in. Nice work!

Please ensure that the original comment in this thread contains a clear explanation of what the change does, why it's important (what problem does it solve?), and, if relevant, include things like code samples and/or performance numbers.

This content may not be exactly what goes into the blog post, but it will help the team putting together the announcement.

Thanks!

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware blog-candidate Consider mentioning this in the release blog post
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Under certain circumstances, the HttpLogging middleware does not follow the ResponseBodyLogLimit setting
6 participants