Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Updating NuGet version to 4.3.0-preview3-4132 #6754

Closed

Conversation

jainaashish
Copy link

Updating NuGet version to 4.3.0-preview3-4123

@emgarten @rrelyea @natidea @livarcocc @dsplaisted @srivatsn

@dnfclas
Copy link

dnfclas commented Jun 2, 2017

@jainaashish,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@livarcocc
Copy link

This insertion seems to still have a bug that I talked to @emgarten about: /opt/code/TestAssets/TestPackages/dotnet-dependency-context-test/https:/dotnet.myget.org/F/templating/api/v3/index.json

It seems that https:// sources are being escaped wrong and https:// is being translated into http:/. Single forward slash. I ran into this when trying to insert a private of these bits earlier this week.

@emgarten
Copy link
Member

emgarten commented Jun 3, 2017

I'll take a look at the failure

@emgarten
Copy link
Member

emgarten commented Jun 5, 2017

The http source failure is caused by dotnet/msbuild#1622, Restore now reads sources from the project file and stores them as a property. I've added a workaround to NuGet and will create a new PR with the updated packages.

@livarcocc livarcocc changed the title Updating NuGet version to 4.3.0-preview3-4123 Updating NuGet version to 4.3.0-preview3-4132 Jun 5, 2017
@nkolev92
Copy link

nkolev92 commented Jun 5, 2017

Closing in favor of #6766 which contains the fix for paths

@jainaashish
Copy link
Author

@nkolev92 is taking care of this integration via separate PR

@jainaashish jainaashish closed this Jun 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants