Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extension methods into the extended type #1896

Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1951
Closed
Tracked by #1891

Move extension methods into the extended type #1896

jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1951
Assignees
Labels
Milestone

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022

    // Guidline: DO NOT put extension methods in the same namespace as the extended type unless the intention is to add methods to interfaces, for generic type restriction, or for dependency management.
    //
    // The extension methods on TArgument should all move to be instance methods on the Argument class.  Since they were implemented as extension methods, I presume they would be non-virtual.
    // The ExistingOnly extension methods are "generic type restriction", so they're OK.  
@jonsequitur jonsequitur mentioned this issue Nov 2, 2022
56 tasks
@jozkee jozkee self-assigned this Nov 4, 2022
@jonsequitur jonsequitur added this to the 2.0 GA milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants