rename symbol types with Cli prefix
#2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
approved these changes
Mar 31, 2023
!| @@ -89,19 +92,19 @@ public ArgumentArity Arity | |||
| /// </example> | |||
| public bool AllowMultipleArgumentsPerToken { get; set; } | |||
|
|
|||
| internal virtual bool IsGreedy | |||
| internal virtual bool Greedy | |||
There was a problem hiding this comment.
great idea to rename the internal properties as well! 👍
| @@ -6,25 +6,27 @@ namespace System.CommandLine | |||
| /// Enables the use of the <c>[parse]</c> directive, which when specified on the command line will short | |||
| /// circuit normal command handling and display a diagram explaining the parse result for the command line input. | |||
| /// </summary> | |||
| public sealed class ParseDirective : Directive | |||
| public sealed class ParseDiagramDirective : CliDirective | |||
There was a problem hiding this comment.
The approved name is DiagramDirective. I am going to send a separate PR with a rename and changing [parse] to [diagram] just to start a discussion
|
|
||
| /// <summary> | ||
| /// Indicates whether the result was created implicitly and not due to the option being specified on the command line. | ||
| /// </summary> | ||
| /// <remarks>Implicit results commonly result from options having a default value.</remarks> | ||
| public bool IsImplicit => IdentifierToken is null || IdentifierToken.IsImplicit; | ||
| public bool Implicit => IdentifierToken is null || IdentifierToken.Implicit; |
There was a problem hiding this comment.
thank you for renaming all the properties, including even these which were not officially approved yet. It's great for consistency and should help in the next API review round
|
Thanks for linking the other issues this addressed. @adamsitnik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also renames a number of properties and renames or moves a few other files so that file names match type names.
It fixes #2131.
fixes #1892
fixes #1916