Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AV and AppVerifier failure when exception is being thrown in main #3315

Closed
pakrym opened this issue Oct 6, 2018 · 4 comments · Fixed by dotnet/core-setup#6766
Closed

AV and AppVerifier failure when exception is being thrown in main #3315

pakrym opened this issue Oct 6, 2018 · 4 comments · Fixed by dotnet/core-setup#6766
Assignees
@sdmaclea
Labels
area-Host
Milestone
3.0

Comments

@pakrym
Copy link
Contributor

pakrym commented Oct 6, 2018

We still observe https://github.com/dotnet/core-setup/issues/4315 in addition we see app verifier failures in the same area:

image

Recent dump: \\pkrymets\exchange\hostpolicy\iisexpress.exe.5292.dmp.cab

Assigning @sdmaclea as per https://github.com/dotnet/core-setup/issues/4366#issuecomment-422918909
@sdmaclea
Copy link
Contributor

sdmaclea commented Jun 5, 2019

Took a look at the dmp. Looks like issue is in breadcrumb_writer. Other than that the dump was not particularly useful.

The test which was triggering this was removed in dotnet/aspnetcore#8727.

I suspect the correct fix will be to revise the resource management to make sure they are properly shared between the threads by using smart pointers. I suspect the change will be too large to justify porting back to 2.2.

@sdmaclea
Copy link
Contributor

@steveharter's design for #3229 explicitly stated /EHa was required in the host

Looking at the IIS host source the exception method seems to be set to /EHs. The destructors are not guaranteed to be called in this case and #3229 will have no affect.

@sdmaclea
Copy link
Contributor

sdmaclea commented Jun 17, 2019 •
edited

/cc @jkotalik

dotnet/core-setup#6766 should make setting the generally non-recommended setting /EHa unnecessary for 3.0.

@jkotalik
Copy link
Contributor

👏

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 30, 2020
dougbu added a commit to dotnet/aspnetcore that referenced this issue Aug 25, 2020
@dougbu
Re-enable tests skipped for old reasons
3f50e22 
- appear to have fixes for all of the following:
  - #3835 -> dotnet/runtime#3229, dotnet/runtime#3315
  - #8387
  - #11813
  - #12097
  - #14022
  - #24695
  - dotnet/aspnetcore-internal#1363 -> #6393 -> #4763
  - dotnet/corefx#36024 -> dotnet/runtime#28959 -> dotnet/runtime#29337
  - dotnet/runtime#38126 -> #24513
  - dotnet/runtime#38539
  - dotnet/sdk#12831
@dougbu dougbu mentioned this issue Aug 25, 2020
Closed
dougbu added a commit to dotnet/aspnetcore that referenced this issue Aug 30, 2020
@dougbu
Re-enable tests skipped for old reasons
e7d02dc 
- appear to have fixes for all of the following:
  - #3835 -> dotnet/runtime#3229, dotnet/runtime#3315
  - #8387
  - #11813
  - #12097
  - #14022
  - #24695
  - dotnet/aspnetcore-internal#1363 -> #6393 -> #4763
  - dotnet/corefx#36024 -> dotnet/runtime#28959 -> dotnet/runtime#29337
  - dotnet/runtime#38126 -> #24513
  - dotnet/runtime#38539
  - dotnet/sdk#12831
dougbu added a commit to dotnet/aspnetcore that referenced this issue Sep 7, 2020
@dougbu
Re-enable tests skipped for old reasons
d8fc4dc 
- appear to have fixes for all of the following:
  - #3835 -> dotnet/runtime#3229, dotnet/runtime#3315
  - #8387
  - #11813
  - #12097
  - #14022
  - #24695
  - dotnet/aspnetcore-internal#1363 -> #6393 -> #4763
  - dotnet/corefx#36024 -> dotnet/runtime#28959 -> dotnet/runtime#29337
  - dotnet/runtime#38126 -> #24513
  - dotnet/runtime#38539
  - dotnet/sdk#12831
dougbu added a commit to dotnet/aspnetcore that referenced this issue Sep 9, 2020
@dougbu
Re-enable tests skipped for old reasons
b0f5bbd 
- appear to have fixes for all of the following:
  - #3835 -> dotnet/runtime#3229, dotnet/runtime#3315
  - #8387
  - #11813
  - #12097
  - #14022
  - #24695
  - dotnet/aspnetcore-internal#1363 -> #6393 -> #4763
  - dotnet/corefx#36024 -> dotnet/runtime#28959 -> dotnet/runtime#29337
  - dotnet/runtime#38126 -> #24513
  - dotnet/runtime#38539
  - dotnet/sdk#12831
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sdmaclea sdmaclea

Labels
area-Host
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Revise breadcrumb_writer_t ownership sdmaclea/core-setup
4 participants
@pakrym @jkotalik @msftgits @sdmaclea