Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASM] Invariant culture doesn't work #38126

Closed
pranavkm opened this issue Jun 18, 2020 · 5 comments
Closed

[WASM] Invariant culture doesn't work #38126

pranavkm opened this issue Jun 18, 2020 · 5 comments
Labels
Milestone

Comments

@pranavkm
Copy link
Contributor

Blazor added a test to verify that CultureInfo.InvariantCulture works in WASM. This is failing since upgrading to .NET 5.

// This test verifies that invariant cultue works correctly in WebAssembly environments. The test case is based on the discussions here: https://stackoverflow.com/a/20085219
var string1 = "Strasse";
var string2 = "Straße";

var ordinalComparison = string1.Equals(string2, StringComparison.Ordinal);
var invariantComparison = string1.Equals(string2, StringComparison.InvariantCulture);

Console.WriteLine(ordinalComparison + " " invariantComparison);

Expected: False True
Actual: False False

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Globalization untriaged New issue has not been triaged by the area owner labels Jun 18, 2020
@ghost
Copy link

ghost commented Jun 18, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
Notify danmosemsft if you want to be subscribed.

@pranavkm pranavkm added the arch-wasm WebAssembly architecture label Jun 18, 2020
@tarekgh
Copy link
Member

tarekgh commented Jun 18, 2020

@pranavkm I would hold logging more issues till figuring out if the wasm enabling the invariant globalization mode or not. with this mode, you lose almost all globalization support.

@safern safern removed the untriaged New issue has not been triaged by the area owner label Jun 22, 2020
@safern safern added this to the 5.0.0 milestone Jun 22, 2020
@safern
Copy link
Member

safern commented Jun 22, 2020

I set the milestone to 5.0 since it is related to WASM.

@steveisok
Copy link
Member

Since ICU is going to be enabled for blazor, is this still an issue?

@safern
Copy link
Member

safern commented Jul 23, 2020

I think we can close this now... also now in .NET 5.0, InvariantMode is the same for WASM and non-WASM, before it was the Mono Globalization implementation which differed.

dougbu added a commit to dotnet/aspnetcore that referenced this issue Aug 25, 2020
dougbu added a commit to dotnet/aspnetcore that referenced this issue Aug 30, 2020
dougbu added a commit to dotnet/aspnetcore that referenced this issue Sep 7, 2020
dougbu added a commit to dotnet/aspnetcore that referenced this issue Sep 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants