New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core 2.2.0 #2098

Open
vivmishra opened this Issue Dec 4, 2018 · 14 comments

Comments

Projects
None yet
10 participants
@vivmishra
Member

vivmishra commented Dec 4, 2018

.NET Core 2.2.0

Release Notes
Download 2.2.0

Please report any issues you find with 2.2.0, either responding to this issue, creating a new issue or creating a new issue in one of the following repos:

@TheRealEdwardCullen

This comment has been minimized.

TheRealEdwardCullen commented Dec 6, 2018

Docker image uses file: "https://dotnetcli.blob.core.windows.net/dotnet/Sdk/2.2.100/dotnet-sdk-2.2.100-win-x64.zip" which is "2.2.100-rtm-009602"

Official release is "2.2.100-rtm-009607".

Normally, these files are synchronised, so I can get the hash from the release announcement.

Raised with dotnet-docker as #855

@TheRealEdwardCullen

This comment has been minimized.

TheRealEdwardCullen commented Dec 6, 2018

@AlexSapple

This comment has been minimized.

AlexSapple commented Dec 6, 2018

Hi, after updating my Rest API project to .net core2.2, all the get requests failed with 415 status. After a long headache, it seems that anything that doesn't include a content type header fails - however, surely a GET in REST wouldn't ever include a content type (as there is no request body at all??). Is this behaviour expected? (something in WEBAPI changed?? or something to to with the work around HTTP2??) The identical calls worked without issue on 2.1.6. (This is over HTTP).

thanks.

@KamranShahid

This comment has been minimized.

KamranShahid commented Dec 7, 2018

For Visual studio 2017 .net core 2.2 option should come rather then a need of VS 2019.
I have done easy migration of my .net core 2.0 till .net core 2.1.6 as i update my ide then the nuget packages (and project level if ever needed).
Now though i wanted to use .net core 2.2 in my three applications (two console application which are also act as windows service on windows platform and one web api project ) but i can't

@vivmishra

This comment has been minimized.

Member

vivmishra commented Dec 7, 2018

CC @muratg ; @Eilon for question from @AlexSapple

@vivmishra

This comment has been minimized.

Member

vivmishra commented Dec 7, 2018

@KamranShahid : Sorry for the inconvenience, you can install .NET Core 2.2 using the installer package from the download page and use it with VS 2017. .NET Core 2.2 will show in the project options as a target when you install the 2.2 SDK.

@muratg

This comment has been minimized.

Member

muratg commented Dec 7, 2018

@mkArtakMSFT @rynowak @pranavkm

Could you take a look at @AlexSapple's question above? Related to ProblemDetails feature?

@rynowak

This comment has been minimized.

rynowak commented Dec 7, 2018

@AlexSapple - this is the explanation for what changed aspnet/AspNetCore#4396

@KamranShahid

This comment has been minimized.

KamranShahid commented Dec 8, 2018

@KamranShahid : Sorry for the inconvenience, you can install .NET Core 2.2 using the installer package from the download page and use it with VS 2017. .NET Core 2.2 will show in the project options as a target when you install the 2.2 SDK.

My point is Visual Studio 2017 should have option to update as when we have releases of 2.1.0 til 2.1.6 rather then doing separate sdk download

@vivmishra which particular file i should dowonload, SDK or run time?
I think SDK installer for windows 64 version

@fugaku

This comment has been minimized.

fugaku commented Dec 11, 2018

I can no longer find HttpContentFormDataExtensions in System.Net.Http

Is it moved somewhere?

@tomap

This comment has been minimized.

tomap commented Dec 11, 2018

Hi, we have a "fairly" vanilla ASP.NET Core app, in Docker Linux (microsoft/dotnet:2.2-aspnetcore-runtime)
When we switched from 2.1 to 2.2, we saw a +40Mb increase (from 80Mb to 120Mb)
(same scenario: load the docker, do the 2 same calls to "health" endpoints & swagger endpoints)

We suspect this has something to do with the Garbage collector.
In .Net Core 2.1, we had to add the following to constraint memory use:
<ServerGarbageCollection>false</ServerGarbageCollection>
Maybe the behavior of this has change

Would you have leads on where to look ? how to confirm the hunch :)

Thank you

@muratg

This comment has been minimized.

Member

muratg commented Dec 11, 2018

@MeiChin-Tsai Was there any change in 2.2 to cause any memory usage increase in @tomap's scenario above?

@karelz

This comment has been minimized.

Member

karelz commented Dec 11, 2018

@fugaku why do you think it is gone? See https://apisof.net/catalog/System.Net.Http.HttpContentFormDataExtensions - it should be in System.Net.Http.Formatting.dll, is that not the case?

@dcb99

This comment has been minimized.

dcb99 commented Dec 12, 2018

Hi, after updating my Rest API project to .net core2.2, all the get requests failed with 415 status. After a long headache, it seems that anything that doesn't include a content type header fails - however, surely a GET in REST wouldn't ever include a content type (as there is no request body at all??). Is this behaviour expected? (something in WEBAPI changed?? or something to to with the work around HTTP2??) The identical calls worked without issue on 2.1.6. (This is over HTTP).

thanks.

I had a similar issue, and it was resolved after making sure the program key in launch.json configurations referenced netcoreapp2.2 and not netcoreapp2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment