Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portable pdb guidance in 4.7.1 #1250

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Update portable pdb guidance in 4.7.1 #1250

merged 2 commits into from
Feb 2, 2018

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Feb 2, 2018

Unfortunately due to microsoft/dotnet#529 we had to withdraw Portable PDB from 4.7.1 but we anticipate having the feature restored in 4.7.2 with much improved performance.

Unfortunately due to microsoft/dotnet#529 we had to withdraw Portable PDB from 4.7.1 but we anticipate having the feature restored in 4.7.2 with much improved performance.
@noahfalk
Copy link
Member Author

noahfalk commented Feb 2, 2018

@tmat - look good?

@tmat
Copy link
Member

tmat commented Feb 2, 2018

We should also include info how to enable Portable PDBs in stack traces on 4.7.2 if the app wasn't built against 4.7.2.

Something like:
https://github.com/dotnet/designs-microsoft/blob/symbols2/proposed/publishing-symbols.md#stack-traces

Clarify that in 4.7.2 the issue is targeting, not just what runtime the code is executing on
@noahfalk noahfalk merged commit f548ade into master Feb 2, 2018
@richlander richlander deleted the noahfalk-patch-1 branch May 17, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants