Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to containers #9188

Merged
merged 4 commits into from Mar 12, 2024
Merged

Update references to containers #9188

merged 4 commits into from Mar 12, 2024

Conversation

lbussell
Copy link
Contributor

No description provided.

release-notes/8.0/README.md Outdated Show resolved Hide resolved
release-notes/9.0/README.md Outdated Show resolved Hide resolved
@@ -55,7 +55,7 @@ Download links are provided for each of the distributions at:
- [Microsoft .NET website](https://dotnet.microsoft.com/download/dotnet/8.0)
- [.NET 8 release notes](https://github.com/dotnet/core/blob/main/release-notes/8.0/preview/8.0.0-preview.7.md)

[Container images](https://hub.docker.com/r/microsoft/dotnet/) are provided for Windows (Nano Server, and Server Core) and Linux (Alpine, Debian, and Ubuntu).
[Container images](https://hub.docker.com/r/microsoft/dotnet/) are provided for Linux (Alpine, Debian, Ubuntu, Azure Linux, and distroless variants of Ubuntu and Azure Linux) and Windows (Nano Server and Server Core).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pointing to DH but the main README points to MAR. We should be consistent where we direct people.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I would like to point everything to MAR, but MAR doesn't have product family repos like https://hub.docker.com/r/microsoft/dotnet/. Is the SDK repo on MAR an acceptable replacement or should we send all the links to DH? Or what about linking straight to https://github.com/dotnet/dotnet-docker?

@richlander and @MichaelSimons for input

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are bad?

I'm very torn. Ideally, we primarily reference MAR, but we also need to help people where to look on DH because a lot (perhaps most) of people look there. It's challenging.

Copy link
Contributor Author

@lbussell lbussell Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed all of the links to DH because

  1. We have the product family repo there
  2. We have greater control over the tag discovery/organization situation in our DockerHub readmes
  3. Ultimately users are pulling from mcr.microsoft.com either way.

@lbussell
Copy link
Contributor Author

It is not relevant to this PR to fix the remainder of the broken links. @richlander, @rbhanda when can this be merged?

@rbhanda rbhanda merged commit b281433 into dotnet:main Mar 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants