Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD tests fail to build on Windows 10. Suspect is System.Private.mscorlib.dll #9487

Closed
RussellHaley opened this issue Dec 31, 2017 · 4 comments

Comments

@RussellHaley
Copy link

I submitted a pull request some days back with no comments yet (7days). I am splitting out the issue I am having into a separate er, issue. I modified the build-test.cmd to get them to run, but the build failure seems to be with missing portions of the mscorlib. (see pull request dotnet/coreclr#15627 for changes)

I have not been able to get the FreeBSD tests to successfully build on Windows 10. First I build the FreeBSD corlib, then build the tests:

build.cmd -freebsdmscorlib
Which builds successfully. Running build-test.cmd -buildos FreeBSD sets __buildOS=FreeBSD, __noCrossgen=1, __targetWindows=0

build-test.cmd -buildos FreeBSD
...
baseservices.compilerservices.XUnitWrapper.cs(20,83): error CS0117: 'Assembly' does not contain a definition for 'GetExecutingAssembly'

[c:\Users\russh\Git\dotnet\coreclr\bin\tests\FreeBSD.x64.Debug\TestWrappers\baseservices.compilerservices\baseservices.compilerservices.XUnitWrapper.csproj]

My conjecture at this point is that the correct partial classes for Assembly.cs are not being added when building the FreeBSD System.Private.MsCorlib.dll via build.cmd -freebsdmscorlib

Thoughts? Please let me know which build outputs you would like (pertaining to the aforementioned error).

@jkotas
Copy link
Member

jkotas commented Dec 31, 2017

cc @wfurt

@wfurt
Copy link
Member

wfurt commented May 21, 2018

cc: @mateusrodrigues This may be good to investigate.

@ghost
Copy link

ghost commented May 21, 2018

@RussellHaley, thanks for pushing forward the FreeBSD port. 👍

I was running into similar kinds of issues while attempting https://github.com/dotnet/corefx/issues/24386.

Two things that might interest you: https://github.com/dotnet/source-build/blob/dev/release/2.1/Documentation/boostrap-new-os.md and https://github.com/dotnet/arcade (arcade is the new repo that will consolidate all these similar scripts scattered around the repos, related to this is https://github.com/dotnet/corefx/projects/3).

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@wfurt
Copy link
Member

wfurt commented Feb 16, 2022

this is so old and probably not applicable any more. We should now be able to build & run tests on FreeBSD.

@wfurt wfurt closed this as completed Feb 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants