Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup MSBuild requires a private package for Microsoft.Net.Compilers.Targets.NetCore #4952

Closed
JohnChen0 opened this issue Jan 15, 2016 · 8 comments

Comments

@JohnChen0
Copy link

Resolving issue #4633 requires setting up an MSBuild that runs under CoreCLR. Currently, this setup requires a private NuGet package for Microsoft.Net.Compilers.Targets.NetCore. This package needs to be made available on a public feed.

@dsplaisted
Copy link
Member

I believe @joperezr is going to make sure the package is available, or otherwise modify the buildtools package so it doesn't need this package.

@JohnChen0
Copy link
Author

@joperezr: Do you have an ETA of when we will have buildtools that don't depend on the private NuGet package? Thanks.

@tzwlai
Copy link

tzwlai commented Jan 21, 2016

@joperezr, I have tagged this issue with "blocking-release" since it's currently blocking #4633, which is a blocking issue itself.

CC @leecow

@joperezr
Copy link
Member

The problem is not the dependency in the private packages, since they can be uploaded to the build tools easily. The problem is that the MSBuild that we have right now doesn't run in Mac OS X since it crashes just after we invoke it. @rainersigwald is helping us fix this and hopefully he can get this working today so that we can depend on new packages that work across all platforms.

@rainersigwald
Copy link
Member

@joperezr Tracking that as dotnet/msbuild#441. Currently working to resolve flakiness with build and test after updating our .NET Core dependencies.

@rainersigwald
Copy link
Member

dotnet/msbuild#441 is fixed as of MSBuild packages version 0.1.0-preview-00014 and higher (use 15 since it has another bugfix).

@joperezr
Copy link
Member

The packages have been published and the code change was made with dotnet/buildtools#396
I will generate a new build tools package version with the change and report back the number.

@joperezr
Copy link
Member

Done, package version 00157 contains .Net Core MSBuild. @JohnChen0 if you want to see an example of how to use it, please take a look at dotnet/corefx#5711. The most important files you want to keep an eye on, are init-tools.sh and init-tools.cmd in the corefx repo, and how we call them from the build.cmd and build.sh. If you have any questions please let me know. I'm closing this issue since the package is ready.

@leecow leecow changed the title Setup MSBuild requires a private package for Microsoft.Net.Compilers.Targets.NetCore Setup MSBuild requires a private package for Microsoft.Net.Compilers.Targets.NetCore Jan 27, 2016
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 30, 2020
@msftgits msftgits added this to the 1.0.0-rc2 milestone Jan 30, 2020
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants