Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Move wiki files to coreclr repo #1075

Merged
merged 16 commits into from
Jun 3, 2015
Merged

Conversation

richlander
Copy link
Member

  • Move remainder of wiki documents to CoreCLR repo
  • Intend to keep the wiki open, with one file that provides a small set of helpful links into the repo.

See dotnet/corefx#1879. It is an analogous PR on the CoreFX repo. They should be merged at the same time, since there are links that cross-reference new content.

In response to: https://github.com/dotnet/corefx/issues/1781.

Earlier wiki migration: #662.

/cc @ellismg, @janvorli, @blackdwarf, @terrajobst, @akoeplinger

@akoeplinger
Copy link
Member

Looks great, thanks for doing this work 👍

The only gripe I have left is that currently when I browse the Documentation root I need to scroll down 2+ pages until I get to the rendered readme content, cause there are so many files in the root.

Now that we're no longer limited by the GH wiki's flat file structure, can we move the files into subfolders? I think the categorization you already did on the readme (get-dotnet-core\, project-docs\, coding-guidelines\) would make the most sense. This applies to corefx as well.

@ghost
Copy link

ghost commented May 31, 2015

👍 to the additions and @akoeplinger's suggestion about subdirectories.

@richlander
Copy link
Member Author

Good point @akoeplinger and @jasonwilliams200OK. It was always the plan to wait until good categories of docs presented themselves. That does indeed seem to happening. Let's merge these two PRs first and then figure that out.

@richlander
Copy link
Member Author

Looking for some validation on this one before I merge it and the corefx one.

/cc @janvorli, @jkotas, @kangaroo, @gkhanna79

@kangaroo
Copy link

kangaroo commented Jun 2, 2015

LGTM -- I'm not sure if its an anomaly, but github took FOREVER to render Documentation when I clicked on it in your repo.

@akoeplinger feedback is valid, but I'm not sure its a huge deal. I think if we choose to move to folders, that can be done in a follow up PR.

@ghost
Copy link

ghost commented Jun 2, 2015

github took FOREVER to render

try switching 🅱️rowser!

@richlander
Copy link
Member Author

@kangaroo Just clicked (presumably) on the same buttons and didn't see the big slow-down.

Agreed. No need to re-work the directory structure in this PR, but a good idea.

Thanks for taking a look.

richlander added a commit that referenced this pull request Jun 3, 2015
@richlander richlander merged commit 9da965b into dotnet:master Jun 3, 2015
@richlander richlander deleted the rich-docs-update2 branch June 3, 2015 04:16
blackdwarf pushed a commit that referenced this pull request Jun 7, 2015
As raised in #1075 by @akoeplinger, the Documentation folder's file
list forces the user to scroll way down to see the README.md. This
PR fixes that by storing the documents in separate sub-folders one
per hierarchy of related documents. Also changed
Documentation\README.md and root README.md to take into account
the new paths.
blackdwarf pushed a commit that referenced this pull request Jun 7, 2015
As raised in #1075 by @akoeplinger, the Documentation folder's file
list forces the user to scroll way down to see the README.md. This
PR fixes that by storing the documents in separate sub-folders one
per hierarchy of related documents. Also changed
Documentation\README.md and root README.md to take into account
the new paths.
blackdwarf pushed a commit that referenced this pull request Jun 7, 2015
As raised in #1075 by @akoeplinger, the Documentation folder's file
list forces the user to scroll way down to see the README.md. This
PR fixes that by storing the documents in separate sub-folders one
per hierarchy of related documents. Also changed
Documentation\README.md and root README.md to take into account
the new paths.
blackdwarf pushed a commit that referenced this pull request Jun 10, 2015
As raised in #1075 by @akoeplinger, the Documentation folder's file
list forces the user to scroll way down to see the README.md. This
PR fixes that by storing the documents in separate sub-folders one
per hierarchy of related documents. Also changed
Documentation\README.md and root README.md to take into account
the new paths.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
9 participants